Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
MIME-Version: 1.0
In-Reply-To: <5692D87E.20304@googlemail.com>
References: <CAHYJk3QvRnYxLMb8XsoWB1hU92Qti_fEKt1JgxkyDARrhf1g7g@mail.gmail.com>
	<1450245754-2760-1-git-send-email-mikachu@gmail.com>
	<CAH+w=7btpFWXkgHFjHwMFWZcrVu-ap5+=PAkeidze8NJsz+SoA@mail.gmail.com>
	<20151219094913.GF2358@tarsus.local2>
	<5692D87E.20304@googlemail.com>
Date: Mon, 11 Jan 2016 16:26:22 +0100
Message-ID: <CAHYJk3SWaSvRTCbQGS5iN60JBx4Z49Emfc6dewLrxQ0w_5xrDg@mail.gmail.com>
Subject: Re: PATCH: Add zle-line-pre-redraw hook for highlighting
From: Mikael Magnusson <mikachu@gmail.com>
To: m0viefreak <m0viefreak.cm@googlemail.com>
Cc: Daniel Shahaf <d.s@daniel.shahaf.name>, Bart Schaefer <schaefer@brasslantern.com>, 
	Zsh hackers list <zsh-workers@zsh.org>
Content-Type: text/plain; charset=UTF-8

On Sun, Jan 10, 2016 at 11:17 PM, m0viefreak
<m0viefreak.cm@googlemail.com> wrote:
>
>
> On 19.12.2015 10:49, Daniel Shahaf wrote:
>> Bart Schaefer wrote on Wed, Dec 16, 2015 at 00:05:01 -0800:
>>> On Dec 15, 2015 10:27 PM, "Mikael Magnusson" <mikachu@gmail.com> wrote:
>>>> I haven't received any complaints about 36650 from testers, so I'll go ahead
>>>> and push this.
>>
>> Hooray!
>>
>> This should fix between 2 and 5 z-sy-h issues:
>> https://github.com/zsh-users/zsh-syntax-highlighting/issues/245
>
> One remaining issue with this approach is the fact that this new hook is
> not triggered when a minibuffer such as isearch is active and BUFFER
> changes.
>
> Is it possible to add support for that, too?
>
> I don't know the zle internals very well, and I couldn't figure out the
> right spot to place a call to the hook without causing performance
> issues due to multiple (useless) calls.

You can probably add your redraw hook at the end of your
zle-isearch-update and zle-isearch-exit hooks (not sure if both are
needed). If you don't use them already, just point them directly at
your redraw hook function.

-- 
Mikael Magnusson