Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
MIME-Version: 1.0
In-Reply-To: <20160115062645.GB12223@tarsus.local2>
References: <20160114001336.GA11173@tarsus.local2>
	<56973114.90807@gmx.com>
	<20160115062645.GB12223@tarsus.local2>
Date: Fri, 15 Jan 2016 15:46:09 +0100
Message-ID: <CAHYJk3QLCCVmZf4efzQgxs3haKv2mssQk3cGQXd5fm7DK7dgGg@mail.gmail.com>
Subject: Re: [PATCH] typeset: set $? on incidental error
From: Mikael Magnusson <mikachu@gmail.com>
To: Daniel Shahaf <d.s@daniel.shahaf.name>
Cc: Eric Cook <llua@gmx.com>, zsh workers <zsh-workers@zsh.org>
Content-Type: text/plain; charset=UTF-8

On Fri, Jan 15, 2016 at 7:26 AM, Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> Eric Cook wrote on Thu, Jan 14, 2016 at 00:24:36 -0500:
>> On 01/13/2016 07:13 PM, Daniel Shahaf wrote:
>> > The 'typeset' family of builtins doesn't set $? when one would expect it
>> > to do so:
>> >
>> >     % x=$(true) y=$(exit 42); echo $?
>> >     42
>> >     % local x=$(true) y=$(exit 42); echo $?
>> >     0
>> >
>> > This patch makes 'typeset' behave as ordiary assignment does.
>>
>>
>> But who expects that?
>
> I did.

local/typeset is a command, and it was successful, so I don't see why
$? should be set to anything else than 0.
% true x=$(false); echo $?
0
is technically exactly the same situation as your above second command.

-- 
Mikael Magnusson