Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
From: Bart Schaefer <schaefer@brasslantern.com>
Message-Id: <160120075917.ZM20024@torch.brasslantern.com>
Date: Wed, 20 Jan 2016 07:59:17 -0800
In-Reply-To: <20160120074753.GA13624@tarsus.local2>
Comments: In reply to Daniel Shahaf <d.s@daniel.shahaf.name>
        "Re: bufferwords() lexes a subshell in a shortloop repeat as a string" (Jan 20,  7:47am)
References: <20160115062648.GA14019@tarsus.local2> 
	<20160115094117.5fcde75c@pwslap01u.europe.root.pri> 
	<20160118022558.GC3979@tarsus.local2> 
	<20160118104548.7db26f60@pwslap01u.europe.root.pri> 
	<20160120074753.GA13624@tarsus.local2>
To: zsh-workers@zsh.org
Subject: Re: bufferwords() lexes a subshell in a shortloop repeat as a string
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii

On Jan 20,  7:47am, Daniel Shahaf wrote:
}
} bufferwords() received the "(x)" as a STRING token, so I looked further
} down, into gettok().  The attached patch seems to do the trick [see the
} added tests].  However, to paraphrase Knuth, I only tested this code,
} not proved it correct.  I'd appreciate a review.

I haven't tried compiling with the patch, but of course the interesting
test case is something like

repeat $( : complicated thing ending with; print $number ) (echo foo)

I.e. syntax is not "repeat TOKEN command" it's "repeat WORD command"

Also what's the reason for the trailing underscore on "inrepeat_"?  That
isn't done anywhere else in the source.