Subject: Re: C02cond.ztst segfaults (was: Re: Strange test suite behaviour since zsh 5.2-dev-1: C02cond.ztst no more reports its finishing)
From: Axel Beckert <[email-masked]>
To: [email-masked]
Cc: Debian Zsh Maintainers <[email-masked]>
Date: Mon, 1 Feb 2016 00:20:37 +0100
List-Id: Zsh Workers List <zsh-workers.zsh.org>

Hi Bart,

On Sun, Jan 31, 2016 at 03:12:51PM -0800, Bart Schaefer wrote:
> On Feb 1, 12:03am, Axel Beckert wrote:
> } Program terminated with signal SIGSEGV, Segmentation fault.
> } #1  0x000055e7dc4af8f4 in is_cond_binary_op (str=0x7f05376fe238 "non-empty-string") at ../../Src/text.c:63
> 
> Try this:
> 
> diff --git a/Src/text.c b/Src/text.c
> index 04acd2a..cf6d3eb 100644
> --- a/Src/text.c
> +++ b/Src/text.c
> @@ -47,7 +47,7 @@ int text_expand_tabs;
>   */
>  static const char *cond_binary_ops[] = {
>      "=", "!=", "<", ">", "-nt", "-ot", "-ef", "-eq",
> -    "-ne", "-lt", "-gt", "-le", "-ge", "=~"
> +    "-ne", "-lt", "-gt", "-le", "-ge", "=~", NULL
>  };
>  
>  static char *tptr, *tbuf, *tlim, *tpending;

Thanks! That fixed at least my local segfault when compiling with
-fPIE. Will now push that patch to our Jenkins. Hopefully this also
fixes the 32-bit C02cond.ztst issues, at least the symptoms are the
same.

		Kind regards, Axel
-- 
/~\  Plain Text Ribbon Campaign                   | Axel Beckert
\ /  Say No to HTML in E-Mail and News            | [email-masked]  (Mail)
 X   See http://www.nonhtmlmail.org/campaign.html | [email-masked] (Mail+Jabber)
/ \  I love long mails: http://email.is-not-s.ms/ | http://abe.noone.org/ (Web)