Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham autolearn_force=no version=3.4.0 Date: Mon, 1 Feb 2016 00:20:37 +0100 From: Axel Beckert To: zsh-workers@zsh.org Cc: Debian Zsh Maintainers Subject: Re: C02cond.ztst segfaults (was: Re: Strange test suite behaviour since zsh 5.2-dev-1: C02cond.ztst no more reports its finishing) Message-ID: <20160131232037.GR4726@sym.noone.org> Mail-Followup-To: zsh-workers@zsh.org, Debian Zsh Maintainers References: <20160131201933.GL4726@sym.noone.org> <160131125145.ZM12147@torch.brasslantern.com> <20160131230313.GP4726@sym.noone.org> <160131151251.ZM12994@torch.brasslantern.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <160131151251.ZM12994@torch.brasslantern.com> X-Operating-System: Linux 3.2.0-4-amd64 X-Machine: sym2 x86_64 X-Editor: GNU Emacs 23.4.1 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAAAAAC3mUtaAAAABGdBTUEAALGPC/xhBQAAADh0RVh0U29mdHdhcmUAWFYgVmVyc2lvbiAzLjEwYSAgUmV2OiAxMi8yOS85NCAoUE5HIHBhdGNoIDEuMindFS5JAAACGElEQVQ4jXXQMU8UYRDG8f8shNjdDH4AbpfGDjAWlKiJiZ0ajL1aGCvsNCbGaCGG1koLaztaTYz6ATy+gOyehYmF3MxVxgg3FnDsHcTpJr/M+8w7Rf6nCsaVTTDqxbg9hoOXmw83H71+Eyfg4E1d7/Z2fG9rGkZbTQiu+K+3U/C+76lmkvAhJuDndnoAiftou4V84okAGclop4U/jYACZDTxrYWP0gkxVfAm/W//GLZpxIzwIN0Hn8dw0B+IWkZmQmRsj2HfhwokEklHfNCCiQCRgAR7YyhQVRVTCKCzP4Y5zBBE0t0zY3Q8oQaBqqAMlVEcgVQd9706zGirAFium8HXumlMIeMwqQCInju+2+uB6MRENupdpMt8pRlHZyuAW0F+Mb6XSIVqtxjD+iVmVqqystLEzFTGT92YqRaXpNT5eTVjeJhbALPnrTxLUZUKZsgxcNm64hAOYisT/xhF+oKTGU5RegtC3Rt6eEDi/QnIevdTx9Md2EMmYBRmCQR1026FCGQQJJExsRUqgkMGaWSbwYLnoO4T6VgpbQbdELPMBAHWWrhYrcxXnYgAsatPWygkFCBD4K62MAsOTqA6szYRPpsu6e6Y8mPiVrBMNuGIMrgwBUu4p2DgG1Ownu6hpuTv7hScefHAzAC/yRRw5U5pALMbJ4AUALvHSZhxgHPXTsHcdWD1GadAHr9avP+c0wCr7263Df8ASLwXWHWs+KIAAAAHdElNRQfYBQEBODPr Organization: DeuxChevaux.org -- The =?iso-8859-1?Q?Citr?= =?iso-8859-1?B?b+tu?= 2CV Database User-Agent: Mutt/1.5.21 (2010-09-15) X-Seq: zsh-workers 37860 Hi Bart, On Sun, Jan 31, 2016 at 03:12:51PM -0800, Bart Schaefer wrote: > On Feb 1, 12:03am, Axel Beckert wrote: > } Program terminated with signal SIGSEGV, Segmentation fault. > } #1 0x000055e7dc4af8f4 in is_cond_binary_op (str=0x7f05376fe238 "non-empty-string") at ../../Src/text.c:63 > > Try this: > > diff --git a/Src/text.c b/Src/text.c > index 04acd2a..cf6d3eb 100644 > --- a/Src/text.c > +++ b/Src/text.c > @@ -47,7 +47,7 @@ int text_expand_tabs; > */ > static const char *cond_binary_ops[] = { > "=", "!=", "<", ">", "-nt", "-ot", "-ef", "-eq", > - "-ne", "-lt", "-gt", "-le", "-ge", "=~" > + "-ne", "-lt", "-gt", "-le", "-ge", "=~", NULL > }; > > static char *tptr, *tbuf, *tlim, *tpending; Thanks! That fixed at least my local segfault when compiling with -fPIE. Will now push that patch to our Jenkins. Hopefully this also fixes the 32-bit C02cond.ztst issues, at least the symptoms are the same. Kind regards, Axel -- /~\ Plain Text Ribbon Campaign | Axel Beckert \ / Say No to HTML in E-Mail and News | abe@deuxchevaux.org (Mail) X See http://www.nonhtmlmail.org/campaign.html | abe@noone.org (Mail+Jabber) / \ I love long mails: http://email.is-not-s.ms/ | http://abe.noone.org/ (Web)