Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
From: Bart Schaefer <schaefer@brasslantern.com>
Message-Id: <160210101846.ZM2333@torch.brasslantern.com>
Date: Wed, 10 Feb 2016 10:18:46 -0800
In-Reply-To: <CAKc7PVCJFXCt+EVkYw3B7NDAUvdphgUuX6yjbt8mQYbv1Mx01w@mail.gmail.com>
Comments: In reply to Sebastian Gniazdowski <sgniazdowski@gmail.com>
        "Re: Slow highlighting (Re: "drop-in replacement" and transpose-words-match)" (Feb 10,  5:32pm)
References: <160111233259.ZM6719@torch.brasslantern.com> 
	<CAKc7PVDhxbVgmV7WcGgyDzMmWSjwQ=7=LExXTwr7YvPzPpn2RA@mail.gmail.com> 
	<160118223126.ZM28565@torch.brasslantern.com> 
	<CAKc7PVB-X+DYVEHRqSoOiDAjNeTsVyz=EN72FHQuF=AnRmh65A@mail.gmail.com> 
	<160119195608.ZM31931@torch.brasslantern.com> 
	<20160123235303.GE20278@tarsus.local2> 
	<160123222057.ZM16192@torch.brasslantern.com> 
	<CAKc7PVCJFXCt+EVkYw3B7NDAUvdphgUuX6yjbt8mQYbv1Mx01w@mail.gmail.com>
To: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: Slow highlighting (Re: "drop-in replacement" and transpose-words-match)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii

On Feb 10,  5:32pm, Sebastian Gniazdowski wrote:
}
} Isn't it that zsyh does a fork for each token it analyzes?

_zsh_highlight_main__type does appear to be called slightly more often
than once per line on a sample function body.  However it doesn't take
much time:

1.602947000e+00 local res="$(_zsh_highlight_main__type ${expanded_arg})"
1.603546000e+00 _zsh_highlight_main__type ${expanded_arg}
1.603900000e+00 if (( $#options_to_set )) ; then ; setopt $options_to_set ; fi
1.603988000e+00 (( $#options_to_set ))
1.604063000e+00 LC_ALL=C builtin type -w -- $1 2> /dev/null
1.604682000e+00

That's 0.001735 seconds per call on my system.  Not enough to account by
itself for the noticeable delay, I think.  It's true that most of that
time is managing the fork -- each call could be be 0.0012 or so faster
without forking -- but I'd still be surprised if that clears it all up.