Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM autolearn=ham autolearn_force=no version=3.4.1 Subject: Re: Bug in completion for git merge To: Daniel Shahaf References: <6E7E611B-CA0B-4F79-B775-7D100CA9017B@gmail.com> <160215085854.ZM27144@torch.brasslantern.com> <8D34A413-897D-4D27-8FD4-4958FC0A90C4@gmail.com> <56C29140.304@gmx.com> <20160216104941.GA16066@tarsus.local2> Cc: zsh-workers@zsh.org From: Eric Cook X-Enigmail-Draft-Status: N1110 Message-ID: <56C32D65.4070902@gmx.com> Date: Tue, 16 Feb 2016 09:08:37 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160216104941.GA16066@tarsus.local2> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:So72MErmqUApMcS7ywG5bXMJYEDoiX3hoefEk9PWjy3o9/NApyn aZqv/d/RYritWOZwEakXsh6vK02NT36hqECvjjaNvrtYWGOmgFht+U+jfn8PxanZDh7RuWl BPVQoE2Xq606ALNL1rvfhiKL4za7RmtNPY7gT2KAo1umtPW1y/zUtbLEwJVVCZaguWXjkdy bOa7lIGW65HABKHadBOEw== X-UI-Out-Filterresults: notjunk:1;V01:K0:uBClIS/abjk=:fANHM+FgtfxS2YvqxQErTe scX+ots3OMoj8DFruVexKJ2mhl76xBA6Ex+XqYq0YfFUdKbcVEFN7eyV7u3pA82mAee9pYQii Im1dHqpbeLkYPJgQzUEJXt4Yw4Y7kfPZTHdzbrhAun31ro+366P/31fsycpeqPa525vSPUq6+ SWxzQIJ50n1TVgJA3y2CZvgUsAZli9agd8ujP8RsgQyftn1lM/vyGgDyjszdiTJxq4FULNe/D pci4DvJVuegzlAbYhVjcVmHicyeYV1ikVMPLFjwYN3B1jnax5P1ynquIO4TqMK4Hf2an8H4Dx 15mMTaCUZBb3dfq9CErOKDIt3del4/lnwi4cSZznsxshYyjwC7T4AeYVe6Gk5wPl0jp40oTxS tlAWtNsmA+A/j0fbx9wSzSMR0xXYxd6iDjyexIVKS93SeWUkl+iZ+VBJFVy901bFYXZRsiLms 4P6HoUTd36ZY9/qOuX4Vir+zwiwafbyZqT1cfIL0XSqtikhcpujCy47BEseKXhDD3qF/oU8Bn 061xGWT/jz0dj99PlmdHtCIGjCftiMpdNJZ/5Rq5sOlxf38Nltekm4nmEaUsqFxEow4AFscYW 24KdLzAkETpnVsjz/cMmr+j9YkqKybKeSDFYopndFOgBDut3GfC2B4A0vsSUfvuJHdNGyql9e fR0bu9rH+5yQGK6pXiEZ6wUvq9FijmjDnz9q7bFUoGTwmk7xOyFRoaRFYlV/Qw1iBvAwqu4fM M0SYa3pbLGuJrOlSzeVR1d8rXDe/bgIFmuFKXYFWPGok0Un2/LVJHRhc/XBg+kbSsvHAu/UpN ZfPeSH7EiWvQzdBOFdKV6V5s1m3WQ== X-Seq: zsh-workers 38000 On 02/16/2016 05:49 AM, Daniel Shahaf wrote: > I don't have a strong opinion regarding the specific patch. It's > obviously correct. > > However, what should we do with the other instances of the > backwards-incompatible syntax that are currently in Completion/ and > Functions/? > > If we want to make $fpath backwards-compatible, we'd need to change all > of them and stop adding new instances of backwards-incompatible > syntaxes... which effectively means we'd stop eating our own dogfood. I wasn't trying to imply that fpath should be backwards compatible indefinitely or that using completers from master with older shells is the smartest of ideas*. Just that in this particular instance, since the completer has already long used typeset in the old way; that reverting this one would make typeset's usage consistent throughout this sole function. * Even i've picked individual completers from master that i knew fixed bugs like users/20219, discarding them once i have a newer release on that machine.