Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
From: Greg Klanderman <gak@klanderman.net>
To: zsh-workers@zsh.org
Subject: Re: ZSH_SCRIPT
Reply-To: Greg Klanderman <gak@klanderman.net>
Date: Wed, 02 Mar 2016 16:33:45 -0500
In-Reply-To: <20160302155610.54c9b388@pwslap01u.europe.root.pri> (Peter Stephenson's message of "Wed, 02 Mar 2016 15:56:10 +0000")
Message-ID: <87y4a05zuu.fsf@lwm.klanderman.net>
User-Agent: Gnus/5.1008 (Gnus v5.10.8) XEmacs/21.4.22 (linux)
References: <22221.59800.803540.618862@lwm.klanderman.net>
	<160224143153.ZM28994@torch.brasslantern.com>
	<20160225093344.0d2499d5@pwslap01u.europe.root.pri>
	<87r3g08ycp.fsf@lwm.klanderman.net>
	<160225150425.ZM14095@torch.brasslantern.com>
	<87lh6384y5.fsf@lwm.klanderman.net>
	<20160301092746.1472ae95@pwslap01u.europe.root.pri>
	<87fuwa8dpk.fsf@lwm.klanderman.net>
	<20160301150707.2ee18f01@pwslap01u.europe.root.pri>
	<874mcq889m.fsf@lwm.klanderman.net>
	<160301103630.ZM8094@torch.brasslantern.com>
	<871t7u7y7a.fsf@lwm.klanderman.net>
	<20160302093034.6e9086a2@pwslap01u.europe.root.pri>
	<87a8mg7ued.fsf@lwm.klanderman.net>
	<20160302155610.54c9b388@pwslap01u.europe.root.pri>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii

>>>>> On March 2, 2016 Peter Stephenson <p.stephenson@samsung.com> wrote:

> On Wed, 2 Mar 2016 10:48:42 -0500
> Greg Klanderman <gak@klanderman.net> wrote:
>> Did you want this ztrdup in or not:
>> 
>> zsh_script = ztrdup(runscript);

> I think it makes sense (unless it's duplicated again).

well, as it currently stands there is that ztrdup() shown above in
zsh_main() and then another here in createparamtable():

    setsparam("ZSH_SCRIPT", ztrdup(zsh_script));

Yesterday, a few emails back in this thread Bart had said he thought
there should probably be a ztrdup() in zsh_main() but that maybe it
was not needed due to the one in createparamtable().

>> It looks like ZSH_NAME comes from argv[0] immediately after the early
>> metification you pointed out above, but is being re-metified here:
>> 
>> setsparam("ZSH_NAME", ztrdup_metafy(zsh_name));

> That's probably wrong for the reasons I gave, unless I'm missing
> something basic.

OK, I will fix that in the next version of the patch I send.

Greg