Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham autolearn_force=no version=3.4.1 X-AuditID: cbfec7f5-f79b16d000005389-60-56d97a14f656 Date: Fri, 04 Mar 2016 12:05:37 +0000 From: Peter Stephenson To: Baruch Siach , zsh-workers@zsh.org Subject: Re: [PATCH] configure: use user set pcre-config Message-id: <20160304120537.1829da7f@pwslap01u.europe.root.pri> In-reply-to: References: Organization: Samsung Cambridge Solution Centre X-Mailer: Claws Mail 3.7.9 (GTK+ 2.22.0; i386-redhat-linux-gnu) MIME-version: 1.0 Content-type: text/plain; charset=US-ASCII Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrNLMWRmVeSWpSXmKPExsVy+t/xy7oiVTfDDJY/FLVYce0Ni8XB5odM DkwecxtuMXmsOviBKYApissmJTUnsyy1SN8ugStj+qRm1oKjHBX95yawNDB+Z+ti5OSQEDCR +DS7hwnCFpO4cG89UJyLQ0hgKaPE0mcLmCGcBiaJW+s/sEI4pxklTm64yQLhnGGUOPbpNCtI P4uAqsSa+ddYQGw2AUOJqZtmM4LYIgKWEifXrmIGsYUFLCR6Jr1iB7F5BewlXuz7BhbnFIiS +DvxM1hcSCBSYsOxZrA4v4C+xNW/n6Dus5eYeeUMI0SvoMSPyffAdjELaEls3tbECmHLS2xe 85YZYo66xI27u9knMArPQtIyC0nLLCQtCxiZVzGKppYmFxQnpeca6RUn5haX5qXrJefnbmKE BPnXHYxLj1kdYhTgYFTi4b3RcD1MiDWxrLgy9xCjBAezkghvTObNMCHelMTKqtSi/Pii0pzU 4kOM0hwsSuK8M3e9DxESSE8sSc1OTS1ILYLJMnFwSjUwSt1euezN7bxLyzkbtTdyBogJdO// yOhxaLNtV1F+T/flss51fnXLuK070y/e2vpk856XHh5OV9bF62wwXBViYdne4vXT9OhqwasL TmwwVnvlmjYjbeb/m6dlr96vnrPW9f30Yx/nenwRXpX2P/xq4YkFir83d51rsXTdaPNHbI0u l2LmNoezdkosxRmJhlrMRcWJAOogd2VuAgAA X-Seq: zsh-workers 38090 On Thu, 3 Mar 2016 23:37:27 +0200 Baruch Siach wrote: > Setting a non default configuration script location is common practice when > cross compiling, since the target library might need different flags. zsh > configure scripts allows the user to set pcre-config location but doesn't > actually use it. Fix this. Thanks, that looks fine and I've committed it. I wonder if we should be doing something similar further up? I was evidently a bit tentative when I committed the code here since it insists only on tweaking the flags if the pcre-config set up was standard. But I don't know this is actually a problem. if test x$enable_pcre = xyes; then AC_CHECK_PROG([PCRECONF], pcre-config, pcre-config) dnl Typically (meaning on this single RedHat 9 box in front of me) dnl pcre-config --cflags produces a -I output which needs to go into dnl CPPFLAGS else configure's preprocessor tests don't pick it up, dnl producing a warning. if test "x$ac_cv_prog_PCRECONF" = xpcre-config; then CPPFLAGS="$CPPFLAGS `pcre-config --cflags`" fi fi pws