Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_DKIM_INVALID
	autolearn=ham autolearn_force=no version=3.4.1
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=brasslantern-com.20150623.gappssmtp.com; s=20150623;
        h=from:message-id:date:in-reply-to:comments:references:to:subject
         :mime-version;
        bh=HgoGl1a4oIKaAKWcqrduRf6kTRB5DhhQmC+XdFMlpsA=;
        b=fpBlavxnBIYaIgrBvfrVqMGWa7qPr4TvT2cc4DzTkJycs+O0Dw56DL+uZcYzW85hwu
         /SBI7kaTp9FZnvsX9Sktg6j2DZkyRWLbn8NtulTv+wrO1yWY75JdXTDIo3T3zXaY1R7B
         z1lJwgY39iUJhZoJ3da3h8gXmfLMJok8BCnOthRtijkQxGgd5xviYQGeHJJzUWrQLOCF
         0ZVWb2Tl0ByMyUW7cFiLtwtvlwa2N4BD2p8MNq9Wsuu7zdAiOTJ8Uk899YIzrCpnpYyI
         kyTZT9rglbgIuOIAh0l6oO64Yqs6nM1E0R529FMm78XCDbqLJQONREH8d5aJbbzHN+f/
         Aeuw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
        h=x-gm-message-state:from:message-id:date:in-reply-to:comments
         :references:to:subject:mime-version;
        bh=HgoGl1a4oIKaAKWcqrduRf6kTRB5DhhQmC+XdFMlpsA=;
        b=MMVo3UAyHRTrfsfwJYXkK/0l7BsnBQmpLrabgsXQ9Azo4sx3fUrJzKkWKaQbQ9TZib
         1N1bVVttv9ki28k3+oiqD61uH7aqRvOTFkrt05D0rz79GNCqcviorE69Sc/zxRuDfh8T
         HzAs3upW4iNPTe5pqneJsD4x+duAvJuhfXgmyaTWlmR7nsAsQSkKzwFZQSG+025KzrnC
         6SzZuWjRNe6uhiYv4TsMtHZGiJCc+/lgcyBgJmoEquc1DcsebRtPfXu5TPGN5XIks+Z8
         doBuk+I7PyCN/i5miHooXv4Ny2wqsglUoD9IrlRis3gznomraIZD89CzPkhML8j0wTNB
         WiIA==
X-Gm-Message-State: AD7BkJI7tXBBjk6wE8clxbAUChtuyJ0dhsYq7wEcoyw7TCpUj/sk1vlIv2RI0VNpbtp30w==
X-Received: by 10.66.145.194 with SMTP id sw2mr27314149pab.69.1457286112600;
        Sun, 06 Mar 2016 09:41:52 -0800 (PST)
From: Bart Schaefer <schaefer@brasslantern.com>
Message-Id: <160306094154.ZM20831@torch.brasslantern.com>
Date: Sun, 6 Mar 2016 09:41:54 -0800
In-Reply-To: <8456.1456706752@thecus.kiddle.eu>
Comments: In reply to Oliver Kiddle <okiddle@yahoo.co.uk>
        "Re: reverse-menu-complete re-starting completion on 5.2?" (Feb 29,  1:45am)
References: <20160226175937.GA22547@lorien.comfychair.org> 
	<160226114511.ZM17604@torch.brasslantern.com> 
	<8456.1456706752@thecus.kiddle.eu>
X-Mailer: OpenZMail Classic (0.9.2 24April2005)
To: Zsh workers <zsh-workers@zsh.org>
Subject: Re: reverse-menu-complete re-starting completion on 5.2?
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Seq: zsh-workers 38102

Meant to respond to this a while ago ...

On Feb 29,  1:45am, Oliver Kiddle wrote:
} 
} Even before that commit I can reproduce a variant of the problem by
} starting menu completion with reverse-menu-complete and then switching
} to a forwards menu complete.

Not surprising, really.

} [...] I'm really not sure why we need to be so
} strict about the completion widget matching the last completion widget.

The only reason I can think of is in case menu completion is invoked from
within a user-defined widget, or otherwise entered by a different widget
than simple forward/reverse menu completion.  In that instance the user is
presumably not continuing with the menu in progress but instead wants to
start over.  I.e. similar to tests of $LASTWIDGET in Functions/Zle/*.

} anyone foresee any problem with just relaxing the condition (see patch).

Maybe we'd need another flag action for "zle -f" to continue/interrupt a
menu in progress, but probably it will work as expected more often with
the patch than without.  I suggest you push and we'll find out if a need
for a flag arises.