Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
Subject: Re: [PATCH] Expose isearch and suffix regions to widgets.
To: zsh-workers@zsh.org
References: <1457905871-2808-1-git-send-email-m0viefreak.cm@googlemail.com>
 <CAH+w=7Z-xQKMoNVK2MeOyj1ND22B8-yceU8FSfCp3xm6kyKEzQ@mail.gmail.com>
 <CAH+w=7a=z+BnQmv027+4+3=KCEGXgtVf7hs+aSp+aVqKLJnebQ@mail.gmail.com>
From: m0viefreak <m0viefreak.cm@googlemail.com>
Message-ID: <570A50CF.2000600@googlemail.com>
Date: Sun, 10 Apr 2016 15:10:39 +0200
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.2
MIME-Version: 1.0
In-Reply-To: <CAH+w=7a=z+BnQmv027+4+3=KCEGXgtVf7hs+aSp+aVqKLJnebQ@mail.gmail.com>
Content-Type: multipart/mixed;
 boundary="------------080703090301030106070700"

--------------080703090301030106070700
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

On 10.04.2016 07:35, Bart Schaefer wrote:
>> Sorry for the belated reply to this, but could you provide an example
>> in which the ISEARCH_* variables are useful?

Like the patch 36445 for yank, this is used by the
zsh-syntax-highlighting script. With this change, the matched part of
BUFFER can be queried in zle-isearch-update (and something like the
zle_highlight array can be re-created on top of other highlighting,
which was impossible before).

> And if the answer is going to be "during zle-isearch-update" then
> won't ISEARCH_ACTIVE always be true?

No, I actually made a mistake in the docs for the original patch.

ISEARCH_ACTIVE does not describe the fact that the minibuffer is active,
but the fact that a pattern that was typed in there does actually
matches the BUFFER. If the search pattern does not match ("failing
bck-i-search:") nothing is being underlined, and ISEARCH_ACTIVE will be 0.

I attached a small patch to improve the wording in the docs.

--------------080703090301030106070700
Content-Type: text/plain; charset=UTF-8;
 name="0001-Improve-wording-of-the-ISEARCH_ACTIVE-parameter.patch"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
 filename*0="0001-Improve-wording-of-the-ISEARCH_ACTIVE-parameter.patch"

RnJvbSA4N2FhZjc4Mjg0NzUyZDA0ODczYWZmNGVjZTcxMGNjYzMyNzljNTYzIE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBtMHZpZWZyZWFrIDxtMHZpZWZyZWFrLmNtQGdvb2ds
ZW1haWwuY29tPgpEYXRlOiBTdW4sIDEwIEFwciAyMDE2IDE0OjU3OjUxICswMjAwClN1Ympl
Y3Q6IFtQQVRDSF0gSW1wcm92ZSB3b3JkaW5nIG9mIHRoZSBJU0VBUkNIX0FDVElWRSBwYXJh
bWV0ZXIuCgotLS0KIERvYy9ac2gvemxlLnlvIHwgOSArKysrKy0tLS0KIDEgZmlsZSBjaGFu
Z2VkLCA1IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvRG9j
L1pzaC96bGUueW8gYi9Eb2MvWnNoL3psZS55bwppbmRleCAxNjFjZWY3Li5jNDgyYTQ2IDEw
MDY0NAotLS0gYS9Eb2MvWnNoL3psZS55bworKysgYi9Eb2MvWnNoL3psZS55bwpAQCAtODQx
LDEwICs4NDEsMTEgQEAgdmluZGV4KElTRUFSQ0hfRU5EKQogeGl0ZW0odHQoSVNFQVJDSF9B
Q1RJVkUpIChpbnRlZ2VyKSkKIHhpdGVtKHR0KElTRUFSQ0hfU1RBUlQpIChpbnRlZ2VyKSkK
IGl0ZW0odHQoSVNFQVJDSF9FTkQpIChpbnRlZ2VyKSkoCi10dChJU0VBUkNIX0FDVElWRSkg
aW5kaWNhdGVzIHdoZXRoZXIgYW4gaW5jcmVtZW50YWwgc2VhcmNoIG1pbmlidWZmZXIKLWlz
IGFjdGl2ZS4gdHQoSVNFQVJDSF9TVEFSVCkgYW5kIHR0KElTRUFSQ0hfRU5EKSBnaXZlIHRo
ZSBsb2NhdGlvbiBvZgotdGhlIG1hdGNoZWQgcGF0dGVybiBhbmQgYXJlIGluIHRoZSBzYW1l
IHVuaXRzIGFzIHR0KENVUlNPUikuIFRoZXkgYXJlCi1vbmx5IHZhbGlkIGZvciByZWFkaW5n
IHdoZW4gdHQoSVNFQVJDSF9BQ1RJVkUpIGlzIG5vbi16ZXJvLgordHQoSVNFQVJDSF9BQ1RJ
VkUpIGluZGljYXRlcyB3aGV0aGVyIGEgcGFydCBvZiB0aGUgdHQoQlVGRkVSKSBpcworY3Vy
cmVudGx5IG1hdGNoZWQgYnkgYW4gaW5jcmVtZW50YWwgc2VhcmNoIHBhdHRlcm4uIHR0KElT
RUFSQ0hfU1RBUlQpCithbmQgdHQoSVNFQVJDSF9FTkQpIGdpdmUgdGhlIGxvY2F0aW9uIG9m
IHRoZSBtYXRjaGVkIHBhcnQgYW5kIGFyZQoraW4gdGhlIHNhbWUgdW5pdHMgYXMgdHQoQ1VS
U09SKS4gVGhleSBhcmUgb25seSB2YWxpZCBmb3IgcmVhZGluZword2hlbiB0dChJU0VBUkNI
X0FDVElWRSkgaXMgbm9uLXplcm8uCiAKIEFsbCBwYXJhbWV0ZXJzIGFyZSByZWFkLW9ubHku
CiApCi0tIAoyLjcuNAoK
--------------080703090301030106070700--