Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
MIME-Version: 1.0
In-Reply-To: <alpine.LNX.2.00.1604251026300.6490@ming.fruitbat.org>
References: <571BBF3C.50402@matrix.ai>
	<160423151436.ZM6912@torch.brasslantern.com>
	<571CFD70.7090506@matrix.ai>
	<160424113558.ZM3564@torch.brasslantern.com>
	<alpine.LNX.2.00.1604251026300.6490@ming.fruitbat.org>
Date: Mon, 25 Apr 2016 10:47:49 -0700
Message-ID: <CAH+w=7a2mRteXctrxr8=Opod2vZdJR3yfVA2LY+d1Azbq4giVA@mail.gmail.com>
Subject: Re: Possible ZSH bug with IO direction
From: Bart Schaefer <schaefer@brasslantern.com>
To: "Peter A. Castro" <doctor@fruitbat.org>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Content-Type: text/plain; charset=UTF-8

On Mon, Apr 25, 2016 at 10:31 AM, Peter A. Castro <doctor@fruitbat.org> wrote:
>
> I believe the best solution is to teach Zsh code to handle CR+LF properly,

Which means we're back to the "dozens of source modules" you mentioned.
There's no central place for this; because of vagaries of other I/O systems
(e.g. STREAMS modules), there's not even a consistent use of stdio vs.
low-level read/write (though at least they're usually not mixed on the same
descriptors).

I haven't looked closely at this (and have no idea whether it's possible with
the pre-main hook in place) but perhaps put the descriptors back into
binary mode somewhere in exec.c between whatever passes for zfork()
on cygwin and the actual execve() of any external process?  We mostly
know when a zsh builtin vs. an external command is being run.

Either way the external commands are on their own -- the question is
whether they're better off getting binary when they expect text or the
other way around (as currently).