Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
MIME-Version: 1.0
Sender: gssrox001@gmail.com
Date: Tue, 26 Apr 2016 10:31:41 -0400
Message-ID: <CAN3Cs_H0Uz8c7Du53UfvoRcob5zcU8KkNeqHn6vVGaguxNHK9A@mail.gmail.com>
Subject: [Patch] No warnings for `rm /*`
From: Glenn Smith <glennsmith2209@gmail.com>
To: zsh-workers@zsh.org
Content-Type: multipart/mixed; boundary=f46d04289c1ddc1eb5053164264c

--f46d04289c1ddc1eb5053164264c
Content-Type: multipart/alternative; boundary=f46d04289c1ddc1eb0053164264a

--f46d04289c1ddc1eb0053164264a
Content-Type: text/plain; charset=UTF-8

Hi all,
I was reading a reddit thread
<https://www.reddit.com/r/ProgrammerHumor/comments/4ghiac/saw_this_on_my_way_to_uni_command_line_russian/d2hp52s>
today about shells protecting you from `rm -rf /` but not `rm -rf /*` and
remembered how zsh has a feature that warns you before executing `rm *` or
`rm /dir/*`. After a short investigation (and the loss of a few files, but
that's beside the point), I discovered that zsh warns in every case except
`rm /*`.

This seemed like a serious oversight, so I cloned the repository and made a
small patch that should fix this. You can find it attached to this message.
I hope you accept this patch, as this is a simple fix that can save many
people a lot of trouble.

Thanks,
Glenn

--f46d04289c1ddc1eb0053164264a
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi all,<div>I was reading <a href=3D"https://www.reddit.co=
m/r/ProgrammerHumor/comments/4ghiac/saw_this_on_my_way_to_uni_command_line_=
russian/d2hp52s">a reddit thread</a> today about shells protecting you from=
 `rm -rf /` but not `rm -rf /*` and remembered how zsh has a feature that w=
arns you before executing `rm *` or `rm /dir/*`. After a short investigatio=
n (and the loss of a few files, but that&#39;s beside the point), I discove=
red that zsh warns in every case except `rm /*`.</div><div><br></div><div>T=
his seemed like a serious oversight, so I cloned the repository and made a =
small patch that should fix this. You can find it attached to this message.=
 I hope you accept this patch, as this is a simple fix that can save many p=
eople a lot of trouble.</div><div><br></div><div>Thanks,</div><div>Glenn</d=
iv></div>

--f46d04289c1ddc1eb0053164264a--
--f46d04289c1ddc1eb5053164264c
Content-Type: text/plain; charset=US-ASCII; name="fix-rm-slash-star.diff"
Content-Disposition: attachment; filename="fix-rm-slash-star.diff"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_inhj1h9i0

ZGlmZiAtLWdpdCBhL1NyYy9leGVjLmMgYi9TcmMvZXhlYy5jCmluZGV4IDUwZWZmNzIuLjNmMGEx
NDEgMTAwNjQ0Ci0tLSBhL1NyYy9leGVjLmMKKysrIGIvU3JjL2V4ZWMuYwpAQCAtMjkwMiwxMyAr
MjkwMiwyMyBAQCBleGVjY21kKEVzdGF0ZSBzdGF0ZSwgaW50IGlucHV0LCBpbnQgb3V0cHV0LCBp
bnQgaG93LCBpbnQgbGFzdDEpCiAJICAgIGlmIChzWzBdID09IFN0YXIgJiYgIXNbMV0pIHsKIAkJ
aWYgKCFjaGVja3JtYWxsKHB3ZCkpCiAJCSAgICB1cmVtbm9kZShhcmdzLCBub2RlKTsKLQkgICAg
fSBlbHNlIGlmIChsID4gMiAmJiBzW2wgLSAyXSA9PSAnLycgJiYgc1tsIC0gMV0gPT0gU3Rhcikg
ewotCQljaGFyIHQgPSBzW2wgLSAyXTsKLQotCQlzW2wgLSAyXSA9IDA7CisJICAgIH0gZWxzZSBp
ZiAobCA+PSAyICYmIHNbbCAtIDJdID09ICcvJyAmJiBzW2wgLSAxXSA9PSBTdGFyKSB7CisJCWNo
YXIgdDsKKwkJaWYgKGwgPiAyKSB7CisJCSAgICB0ID0gc1tsIC0gMl07CisJCSAgICBzW2wgLSAy
XSA9IDA7CisJCX0gZWxzZSB7CisJCSAgICB0ID0gc1tsIC0gMV07CisJCSAgICBzW2wgLSAxXSA9
IDA7CisJCX0KIAkJaWYgKCFjaGVja3JtYWxsKHMpKQogCQkgICAgdXJlbW5vZGUoYXJncywgbm9k
ZSk7Ci0JCXNbbCAtIDJdID0gdDsKKworCQlpZiAobCA+IDIpIHsKKwkJICAgIHNbbCAtIDJdID0g
dDsKKwkJfSBlbHNlIHsKKwkJICAgIHNbbCAtIDFdID0gdDsKKwkJfQogCSAgICB9CiAJfQogCWlm
ICghbmV4dG5vZGUoZmlyc3Rub2RlKGFyZ3MpKSkK
--f46d04289c1ddc1eb5053164264c--