Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
From: Bart Schaefer <schaefer@brasslantern.com>
Message-Id: <160426103624.ZM11049@torch.brasslantern.com>
Date: Tue, 26 Apr 2016 10:36:24 -0700
In-Reply-To: <CAN3Cs_H0Uz8c7Du53UfvoRcob5zcU8KkNeqHn6vVGaguxNHK9A@mail.gmail.com>
Comments: In reply to Glenn Smith <glennsmith2209@gmail.com>
        "[Patch] No warnings for `rm /*`" (Apr 26, 10:31am)
References: <CAN3Cs_H0Uz8c7Du53UfvoRcob5zcU8KkNeqHn6vVGaguxNHK9A@mail.gmail.com>
To: zsh-workers@zsh.org
Subject: Re: [Patch] No warnings for `rm /*`
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii

On Apr 26, 10:31am, Glenn Smith wrote:
} Subject: [Patch] No warnings for `rm /*`
}
} I discovered that zsh warns in every case except `rm /*`.

Thanks.  I think the following simpler patch does the same.

diff --git a/Src/exec.c b/Src/exec.c
index 50eff72..2dcd5bc 100644
--- a/Src/exec.c
+++ b/Src/exec.c
@@ -2902,11 +2902,11 @@ execcmd(Estate state, int input, int output, int how, int last1)
 	    if (s[0] == Star && !s[1]) {
 		if (!checkrmall(pwd))
 		    uremnode(args, node);
-	    } else if (l > 2 && s[l - 2] == '/' && s[l - 1] == Star) {
+	    } else if (l >= 2 && s[l - 2] == '/' && s[l - 1] == Star) {
 		char t = s[l - 2];
 
 		s[l - 2] = 0;
-		if (!checkrmall(s))
+		if (!checkrmall(*s ? s : "/"))
 		    uremnode(args, node);
 		s[l - 2] = t;
 	    }


As an aside:

% rm /nonexistentdir/*
zsh: sure you want to delete all the files in /nonexistentdir [yn]? 

Seems like we could detect when opendir() fails with ENOENT and skip
the prompt, but maybe there are cases of race condition (directory is
created after I type "rm ..." but before /bin/rm is executed?) where
the default answer of "y" would be incorrect.