Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
Date: Sat, 30 Apr 2016 01:28:28 +0000
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Matthew Martin <phy1729@gmail.com>
Cc: zsh-workers@zsh.org
Subject: Re: Bug in C02cont.ztst's -N test
Message-ID: <20160430012828.GA3334@tarsus.local2>
References: <ufa1t5pl0yg.fsf@epithumia.math.uh.edu>
 <160429131027.ZM22749@torch.brasslantern.com>
 <ufashy4ghvy.fsf@epithumia.math.uh.edu>
 <20160430004639.GA1360@tarsus.local2>
 <20160430010131.GA34472@CptOrmolo.darkstar>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20160430010131.GA34472@CptOrmolo.darkstar>
User-Agent: Mutt/1.5.21 (2010-09-15)

Matthew Martin wrote on Fri, Apr 29, 2016 at 20:01:31 -0500:
> @@ -154,7 +155,7 @@
>      ZTST_skip="[[ -N file ]] not supported on Cygwin"
>    elif (( isnfs )); then
>      ZTST_skip="[[ -N file ]] not supported with NFS"
> -  elif { df -k -- ${$({mount || /sbin/mount} | awk '/noatime/ {print $1,$3}'):-""} | tr -s ' ' | fgrep "$(df -k . | tail -1 | tr -s ' ')" } >&/dev/null; then
> +  elif sleep 58; [[ $unmodified_ls == "$(ls -lu $unmodified)" ]]; then
>      ZTST_skip="[[ -N file ]] not supported with noatime file system"
>    else
>      [[ -N $newnewnew && ! -N $unmodified ]]
> 
> but who wants to sleep for 60 seconds? (There's a sleep 2 earlier.)

Couldn't we sleep less, e.g., with the following? —

    elif ! () {
             repeat 58 {
               sleep 1
               if [[ $unmodified_ls != "$(ls -lu $unmodified)" ]]; then return 0; fi
             }
             return 1
           }; then
      ZTST_skip="…"

I assume we don't need to bother with fancy exponential (doubling)
backoffs in this context...

Cheers,

Daniel