Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
MIME-Version: 1.0
In-Reply-To: <57308891.6070906@redhat.com>
References: <57308891.6070906@redhat.com>
Date: Mon, 9 May 2016 15:04:24 +0200
Message-ID: <CAHYJk3RMavCDF0suqeMvxPHQLDVaiOYVxFwz_vuufqhwDy-=JA@mail.gmail.com>
Subject: Re: [PATCH] zsh x font family completion
From: Mikael Magnusson <mikachu@gmail.com>
To: Marko Myllynen <myllynen@redhat.com>
Cc: zsh workers <zsh-workers@zsh.org>
Content-Type: text/plain; charset=UTF-8

On Mon, May 9, 2016 at 2:54 PM, Marko Myllynen <myllynen@redhat.com> wrote:
> Hi,
>
> I'm working on completions for a command which has an option to select
> the font family to use, I was wondering whether X font family
> completions would be worthwhile to add for others to use as well?
>
> Currently there's no any kind of caching, not sure would that be needed
> on modern systems? When I looked at x_font for inspiration, it had a
> big fat sign that its caching "*has* to be improved" so not sure what
> would be considered elegant or optimal here.
>
> Tested on RHEL 7.
>
> ---
>  Completion/X/Type/_x_font_family | 6 ++++++
>  1 file changed, 6 insertions(+)
>  create mode 100644 Completion/X/Type/_x_font_family
>
> diff --git a/Completion/X/Type/_x_font_family b/Completion/X/Type/_x_font_family
> new file mode 100644
> index 0000000..48a1f23
> --- /dev/null
> +++ b/Completion/X/Type/_x_font_family
> @@ -0,0 +1,6 @@
> +#autoload
> +
> +local expl
> +
> +_wanted font-families expl 'font family' compadd "$@" \
> +  ${(f)"$(fc-list : -f "%{family|downcase|delete( )|translate(\,,\n)}\n")"}
>
> Thanks,

It would probably be less confusing if this was called
_fc_font_family, since X fonts are something else. This one should
probably not even be in the X/ directory.

-- 
Mikael Magnusson