Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham
	autolearn_force=no version=3.4.1
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
        h=x-gm-message-state:reply-to:subject:references:to:cc:from
         :organization:message-id:date:user-agent:mime-version:in-reply-to
         :content-transfer-encoding;
        bh=7TPlu1kJjQPj3+MVqFptQwD/xdbCoHMeRmVCwgWHgTU=;
        b=U5xVlYZzXWPpLjbr71lVlEl8hNBV2LSWDLUkm27VKVhrdQ7hmf82gu+52a48xay9vE
         1G1iIBhkLhdIb88fdr0QV8Shdnkl/bTYAyfP+cSHc7DPYHHnsrHiUgAi2OT3ScyydE7E
         mBrSWy7vNOWwikCyFLIVHunYeg91pW81Ac0W9SFfva+osriP/pru5vtALAT7hgOdYbxq
         e+sXQIS+GUw8VEKfKckAQA8mOekqvDVwQLxOsmdpQxIB6KGkihnAPypb+qmnXkuYOzZx
         yldMr64dOgtv/us/xwNHyPvE4rukF/VXnk69p4GCNVCiM2E3ZgEYpXbQJ+YLmYKeAbuB
         RHHA==
X-Gm-Message-State: AOPr4FV6oKENdLfc5d9We0q2KdzXNFxjvbb4jK5k3d6OR4BKM/HyuA16ReoSrcXzvjfLJBYD
X-Received: by 10.28.234.130 with SMTP id g2mr4093799wmi.42.1462967637929;
        Wed, 11 May 2016 04:53:57 -0700 (PDT)
Reply-To: Marko Myllynen <myllynen@redhat.com>
Subject: Re: [PATCH] zsh x font family completion
References: <57308891.6070906@redhat.com>
 <CAHYJk3RMavCDF0suqeMvxPHQLDVaiOYVxFwz_vuufqhwDy-=JA@mail.gmail.com>
To: Mikael Magnusson <mikachu@gmail.com>
Cc: zsh workers <zsh-workers@zsh.org>
From: Marko Myllynen <myllynen@redhat.com>
Organization: Red Hat
Message-ID: <57331D53.9020902@redhat.com>
Date: Wed, 11 May 2016 14:53:55 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.0
MIME-Version: 1.0
In-Reply-To: <CAHYJk3RMavCDF0suqeMvxPHQLDVaiOYVxFwz_vuufqhwDy-=JA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Seq: zsh-workers 38470

Hi,

On 2016-05-09 16:04, Mikael Magnusson wrote:
> On Mon, May 9, 2016 at 2:54 PM, Marko Myllynen <myllynen@redhat.com> wrote:
>>
>> I'm working on completions for a command which has an option to select
>> the font family to use, I was wondering whether X font family
>> completions would be worthwhile to add for others to use as well?
>>
>> Currently there's no any kind of caching, not sure would that be needed
>> on modern systems? When I looked at x_font for inspiration, it had a
>> big fat sign that its caching "*has* to be improved" so not sure what
>> would be considered elegant or optimal here.
>>
>> +_wanted font-families expl 'font family' compadd "$@" \
>> +  ${(f)"$(fc-list : -f "%{family|downcase|delete( )|translate(\,,\n)}\n")"}
>>
> 
> It would probably be less confusing if this was called
> _fc_font_family, since X fonts are something else. This one should
> probably not even be in the X/ directory.

Fair enough - would you happen to have any suggestions on the new name
and location, I could send an updated patch then?

Thanks,

-- 
Marko Myllynen