Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
In-reply-to: <87eg9dmt6f.fsf@ft.bewatermyfriend.org>
From: Oliver Kiddle <okiddle@yahoo.co.uk>
References: <87k2jegi5h.fsf@ft.bewatermyfriend.org> <1462109252-12482-1-git-send-email-ft@bewatermyfriend.org> <27858.1462193719@thecus.kiddle.eu> <87eg9dmt6f.fsf@ft.bewatermyfriend.org>
To: zsh-workers@zsh.org
Subject: Re: [PATCHv3] Refactor baud rate completion
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <19156.1462979335.1@thecus.kiddle.eu>
Date: Wed, 11 May 2016 17:08:55 +0200
Message-ID: <19157.1462979335@thecus.kiddle.eu>

On 7 May, Frank Terbeck wrote:
> I don't know if there is a simple way to make it work the way I'd like
> (unsorted group as well as inheriting the right description), so I ended
> up doing this:
>
>     _description -1V baud-rates expl 'baud rate'
>     compadd "${(@)argv/#-J/-V}" "$expl[@]" -- "${rates[@]}"
>
> That feels pretty dirty, but it seems to work.

That looks like the best approach to me. It's the compadd interface
that's dirty and we're too late to fix that.

> The completion-style-guide mentions the following:
>
>     _description -1V tag expl '...'
>     compadd "$expl[@]" - ...
>
> But that would discard any descriptions given in an _arguments call.

The style guide could be improved to recommend passing on the
arguments.

Oliver