Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
From: Bart Schaefer <schaefer@brasslantern.com>
Message-Id: <160607100329.ZM15469@torch.brasslantern.com>
Date: Tue, 7 Jun 2016 10:03:29 -0700
In-Reply-To: <87fusprngk.fsf@gmail.com>
Comments: In reply to Christian Neukirchen <chneukirchen@gmail.com>
        "Infinite loop with "hash ="" (Jun  7,  6:08pm)
References: <87fusprngk.fsf@gmail.com>
To: zsh-workers@zsh.org
Subject: Re: Infinite loop with "hash ="
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii

On Jun 7,  6:08pm, Christian Neukirchen wrote:
}
} Running "hash =" will trigger an infinite loop, even with the check
} currently implemented.  (Same for "hash =foo".)

Hrmph, that's pretty silly.

diff --git a/Src/builtin.c b/Src/builtin.c
index 6f07fc6..c2fb81e 100644
--- a/Src/builtin.c
+++ b/Src/builtin.c
@@ -3748,6 +3748,7 @@ bin_hash(char *name, char **argv, Options ops, UNUSED(int func))
         if (!(asg = getasg(&argv, NULL))) {
 	    zwarnnam(name, "bad assignment");
 	    returnval = 1;
+	    break;
         } else if (ASG_VALUEP(asg)) {
 	    if(isset(RESTRICTED)) {
 		zwarnnam(name, "restricted: %s", asg->value.scalar);