Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham autolearn_force=no version=3.4.1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:reply-to:to:from:subject:organization:message-id :date:user-agent:mime-version:content-transfer-encoding; bh=UP+HwPT9TK7XtabokUP/f1GEnRw8T8IRDaA+YY7r1vk=; b=MtoaKmqgZYZCWejdGsX4lHOiOzXTwmChJGOpdEPBSf5WyVkVOQlNNuI3RN28/eZwC3 ssFHXFkaiFDeYSsoSLQ79mguzksCUReR1/jN8s7+g88/WDHZMW6hL/27RcF7qiA7UB4p SX2Uigm8uxnxGzmfVTMVZo6clbCRbwba6krDPZBKh43pOtg38aPODvrJgIEUq2hvWUtk xw057nQ1ph9WQRTSczdm7QEFvVnWaJVyxkIHopQrwP7NG6NxFunmAgwOAy3Q7WMUfbKA 7X6vFJfPJNSfyHu3nJvEdfzO1vmBcqYiE5EanlzWDnOrZ1RZyuzM4yBJl8/vcFWIrp86 ZkkQ== X-Gm-Message-State: ALyK8tJDt2RQ9W7SPPJsjCTLG4Yt/BTbMZ8v3mHnXWSljfmKBr9vnXU95aNNRjjLR3nmMit+ X-Received: by 10.28.184.199 with SMTP id i190mr8870902wmf.57.1465466244409; Thu, 09 Jun 2016 02:57:24 -0700 (PDT) Reply-To: Marko Myllynen To: zsh workers From: Marko Myllynen Subject: When local state_descr is needed? Organization: Red Hat Message-ID: <57593D7F.40604@redhat.com> Date: Thu, 9 Jun 2016 12:57:19 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Seq: zsh-workers 38637 Hi, It's a bit unclear to me when local state_descr should be declared. Reading the man page makes me think that it certainly doesn't hurt to do it especially when using the ->string convention but is it in fact needed then to avoid any potential or concrete side-effect? For example, does the patch below matter in practice at all or not? In the file later on there is: "(-f --from-code $exargs)"{-f+,--from-code=}'[specify code set of input file]:code set:->from_codeset' "(-t --to-code $exargs)"{-t+,--to-code=}'[specify code set for output]:code set:->to_codeset' --- Completion/Unix/Command/_iconv | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Completion/Unix/Command/_iconv b/Completion/Unix/Command/_iconv index d040be7..fd74e6b 100644 --- a/Completion/Unix/Command/_iconv +++ b/Completion/Unix/Command/_iconv @@ -1,6 +1,6 @@ #compdef iconv -local expl curcontext="$curcontext" state line variant ret=1 +local expl curcontext="$curcontext" state state_descr line variant ret=1 if _pick_variant -r variant libiconv='GNU*libiconv' glibc='(GNU*libc|EGLIBC|Gentoo)' unix --version; then local -a args Thanks, -- Marko Myllynen