Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
In-reply-to: <57593D7F.40604@redhat.com>
From: Oliver Kiddle <okiddle@yahoo.co.uk>
References: <57593D7F.40604@redhat.com>
To: zsh workers <zsh-workers@zsh.org>
Subject: Re: When local state_descr is needed?
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2041.1465483423.1@thecus.kiddle.eu>
Date: Thu, 09 Jun 2016 16:43:44 +0200
Message-ID: <2042.1465483424@thecus.kiddle.eu>

Marko Myllynen wrote:
>
> It's a bit unclear to me when local state_descr should be declared.
> Reading the man page makes me think that it certainly doesn't hurt to
> do it especially when using the ->string convention but is it in fact
> needed then to avoid any potential or concrete side-effect?

_main_complete declares it local so it mostly isn't needed.

state_descr was added much later so there were many existing functions
that didn't declare it local. Even before, we've often been lax about
declaring opt_args.

I can think of contrived cases where it would be needed. You'd need to
be using it in a state loop where _arguments/_values is also being
called as part of handling a state.

I tend to only declare it in functions that reference it.
I don't think it's really worth patching vast numbers of functions for
it but I wouldn't care either if someone wants to.

Oliver