Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
From: Bart Schaefer <schaefer@brasslantern.com>
Message-Id: <160614140634.ZM18279@torch.brasslantern.com>
Date: Tue, 14 Jun 2016 14:06:34 -0700
In-Reply-To: <160614111054.ZM17893@torch.brasslantern.com>
Comments: In reply to Bart Schaefer <schaefer@brasslantern.com>
        "Re: [PATCH] add-zle-hook-widget" (Jun 14, 11:10am)
References: <160612184453.ZM11316@torch.brasslantern.com> 
	<20160613085219.GA23148@tarsus.local2> 
	<160614111054.ZM17893@torch.brasslantern.com>
To: zsh-workers@zsh.org
Subject: Re: [PATCH] add-zle-hook-widget
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii

On Jun 14, 11:10am, Bart Schaefer wrote:
}
} On Jun 13,  8:52am, Daniel Shahaf wrote:
} } What happens when a zle-line-init already exists when add-zle-hook-widget
} } is first called?  I had such a hook and it was simply discarded.  Should
} } add-z-h-w warn that it is overwriting/redefining an existing hook?
} 
} Hmm, how did that happen?  The test for [[ -z "${widgets[$fn]}" ]]

Two thinkos:

(1) I meant [[ -z "${widgets[$hook]}" ]]

(2) but that doesn't stop a *function* named $hook from being replaced,
    which is probably what you meant.

Yes, something should be done about that.