Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham
	autolearn_force=no version=3.4.1
Date: Tue, 21 Jun 2016 01:41:32 +0000
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Oliver Kiddle <okiddle@yahoo.co.uk>
Cc: zsh-workers <zsh-workers@zsh.org>
Subject: Re: Regression: broken completion on modification time
Message-ID: <20160621014132.GC17100@tarsus.local2>
References: <87oa76172f.fsf@secretsauce.net>
 <160612174712.ZM10957@torch.brasslantern.com>
 <3670.1465855245@thecus.kiddle.eu>
 <160614091402.ZM17103@torch.brasslantern.com>
 <9937.1466008377@thecus.kiddle.eu>
 <20160615232437.GA28886@tarsus.local2>
 <17354.1466180383@thecus.kiddle.eu>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <17354.1466180383@thecus.kiddle.eu>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-Seq: zsh-workers 38725

Oliver Kiddle wrote on Fri, Jun 17, 2016 at 18:19:43 +0200:
> (As an aside, I notice _git has a max-verbose style. Not sure if we can
> change that for consistency with _path_commands.)

Change it how?  I don't see how max-verbose and extra-verbose can be
combined, since the former is an int and the latter a bool.

> Daniel Shahaf wrote:
> > However, with this patch and extra-verbose, the «'' - exactly»
> > alternative doesn't show.  (It's not just "hidden"; each of "- --
> > before" and "+ -- after" take half of $COLUMNS.)
> 
> How would you want to present the exactly match given that it inserts
> nothing? In the past with the match -- description form, we didn't
> include it. With the description only form it is less out-of-place.
> 

As you said later, it'd have to show as «'' -- exactly» or « --
exactly».  (Or we could teach the C code to take '*(om=5)' for "exactly
five")

I mentioned the lack of "exactly" as a difference, but now that I think
about it, I suppose I think the "exactly" _should_ be displayed: firstly,
because displaying more options is better; secondly, because it is
displayed in non-verbose mode, and it'd be odd for setting the "verbose"
style to cause fewer options to be offered.

Another display option would be to use a dummy "string without a match"
as Bart said (compadd -E1) for something like

    → sense
    (for the "exactly" sense, skip/omit this field)
    + -- before
    - -- since

> > I tried to reproduce this in 'zsh -f', but «echo *(m<TAB>» simply cycled
> > between various integers after the 'm'; it didn't give the calendar
> > completion at all.  It still did that with extra-verbose and
> > group-name='' set, I haven't debugged further yet.
> 
> You need to enable menu selection:
>   zstyle ':completion*:default' menu 'select=0'
> Pressing Ctrl-D (list-choices) a couple of times will also work.

Got it, thanks.

Daniel

