Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
In-reply-to: <20150517215341.223ef620@ntlworld.com>
From: Oliver Kiddle <okiddle@yahoo.co.uk>
References: <20150517215341.223ef620@ntlworld.com>
To: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: PATCH: case pattern parsing
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <19006.1466508129.1@thecus.kiddle.eu>
Date: Tue, 21 Jun 2016 13:22:09 +0200
Message-ID: <19007.1466508129@thecus.kiddle.eu>

On 17 May 2015, Peter wrote:
> This patch parses case patterns properly, removing the hack that

I noticed a bug with case statements which git bisect tracks to this
change (workers/35168 or 52aeb9aa). It occurs with a fall-through at the
end of the case statement:

  case whatever in
    *) ;&
  esac

I'm not sure how reproducible it is - seems to be fine on Solaris.
#0  0x000000000042e8bd in execlist (state=0x7ffce20a9ac0, dont_change_job=1,
    exiting=0) at exec.c:1195
1195    code = *state->pc++;
#1  0x000000000046587e in execcase (state=0x7ffce20a9ac0, do_exec=0) at loop.c:669
#2  0x000000000042e7b3 in execsimple (state=0x7ffce20a9ac0) at exec.c:1141
#3  0x000000000042eb28 in execlist (state=0x7ffce20a9ac0, dont_change_job=0, 
    exiting=0) at exec.c:1265
#4  0x000000000042e41b in execode (p=0x7f377b419418, dont_change_job=0, exiting=0, 
    context=0x4bded7 "toplevel") at exec.c:1085
#5  0x000000000045201b in loop (toplevel=1, justonce=0) at init.c:208
#6  0x0000000000455bde in zsh_main (argc=1, argv=0x7ffce20a9e28) at init.c:1688
#7  0x000000000040f640 in main (argc=1, argv=0x7ffce20a9e28) at ./main.c:93

Oliver