Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
From: Bart Schaefer <schaefer@brasslantern.com>
Message-Id: <160621155811.ZM9407@torch.brasslantern.com>
Date: Tue, 21 Jun 2016 15:58:11 -0700
In-Reply-To: <20160621014131.GB17100@tarsus.local2>
Comments: In reply to Daniel Shahaf <d.s@daniel.shahaf.name>
        "Re: [PATCH] add-zle-hook-widget" (Jun 21,  1:41am)
References: <160612184453.ZM11316@torch.brasslantern.com> 
	<20160613085219.GA23148@tarsus.local2> 
	<160614111054.ZM17893@torch.brasslantern.com> 
	<20160615232447.GA29225@tarsus.local2> 
	<160616222055.ZM27034@torch.brasslantern.com> 
	<160618162558.ZM5244@torch.brasslantern.com> 
	<20160621014131.GB17100@tarsus.local2>
To: zsh-workers@zsh.org
Subject: Re: [PATCH] add-zle-hook-widget
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii

On Jun 21,  1:41am, Daniel Shahaf wrote:
} Subject: Re: [PATCH] add-zle-hook-widget
}
} Bart Schaefer wrote on Sat, Jun 18, 2016 at 16:25:58 -0700:
} >  for hook in $hooktypes
} >  do
} > +  # Check for an existing widget, add it as the first hook
} > +  if [[ ${widgets[$hook]} = user:* ]]; then
} > +      zle -A "$hook" "${widgets[$hook]}"
} > +      zstyle -- "$hook" widgets 0:"${widgets[$hook]}"
} 
} The last parameter expansion should strip the "user:" prefix.

No, it shouldn't, because the "zle -A" command creates a new widget
whose name begins with "user:".

This way if you run "add-zle-hook-widget -L" it will show you that the
widget with index zero was the user's previously defined widget.

Yes, this breaks things if the user's widget compares itself to $WIDGET
but there's no way around that [*] because the newly created hook is
the only widget allowed to use the reserved hook-widget name.

[*] A possible fix for this is to omit the -w when calling the widget
from zle, so that $WIDGET remains the hook-widget.  That would look
something like

      for hook in "${(@)${(@on)hook_widgets[@]}#<->:}"; do
          if [[ "$hook" = user:* ]]; then
              # Do not change $WIDGET, it may be tested in $hook
              zle "$hook" -N "$@" || return
          else
              zle "$hook" -Nw "$@" || return
          fi
      done