Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
In-reply-to: <160622101417.ZM12222@torch.brasslantern.com>
From: Oliver Kiddle <okiddle@yahoo.co.uk>
References: <576a3601.43921c0a.46393.50ee@mx.google.com> <23718.1466581326@thecus.kiddle.eu> <160622101417.ZM12222@torch.brasslantern.com>
To: zsh-workers@zsh.org
Subject: Re: [PATCH] print errors to stderr
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <30202.1466676285.1@thecus.kiddle.eu>
Date: Thu, 23 Jun 2016 12:04:45 +0200
Message-ID: <30203.1466676285@thecus.kiddle.eu>

Bart wrote:
> } I think this behaviour is actually intentional. It is arguably not an
> } error - the whence command's purpose is to search for something and
> } report on whether it is found. So it doesn't rely on finding it. Also,
> } this is compatible with csh and tcsh - the which command was a csh thing
> } first.
>
> Maybe it's time for either the doc or a code comment to explain this,

Sounds sensible.

Oliver

diff --git a/Src/builtin.c b/Src/builtin.c
index c2fb81e..bfb9e69 100644
--- a/Src/builtin.c
+++ b/Src/builtin.c
@@ -3633,6 +3633,7 @@ bin_whence(char *nam, char **argv, Options ops, int func)
 		}
 	    }
 	    if (!informed && (wd || v || csh)) {
+		/* this is information and not an error so, as in csh, use stdout */
 		zputs(*argv, stdout);
 		puts(wd ? ": none" : " not found");
 		returnval = 1;
@@ -3652,7 +3653,7 @@ bin_whence(char *nam, char **argv, Options ops, int func)
 	    }
 	    informed = 1;
 	} else {
-	    /* Not found at all. */
+	    /* Not found at all. That's not an error as such so this goes to stdout */
 	    if (v || csh || wd)
 		zputs(*argv, stdout), puts(wd ? ": none" : " not found");
 	    returnval = 1;