Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham
	autolearn_force=no version=3.4.1
Date: Sat, 25 Jun 2016 16:28:07 +0000
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Mikael Magnusson <mikachu@gmail.com>
Cc: zsh workers <zsh-workers@zsh.org>
Subject: Re: [PATCH v2 2/3] Fix the ':A' word modifier on paths with '..'
 components.
Message-ID: <20160625162807.GA9840@tarsus.local2>
References: <20160613085218.GA9572@tarsus.local2>
 <1466474004-4669-1-git-send-email-danielsh@tarsus.local2>
 <1466474004-4669-2-git-send-email-danielsh@tarsus.local2>
 <CAHYJk3QPM+wKmzoT5jhPD90e=kYpdT0Yf2hNXcZd9woUSov+Mg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CAHYJk3QPM+wKmzoT5jhPD90e=kYpdT0Yf2hNXcZd9woUSov+Mg@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-Seq: zsh-workers 38759

Mikael Magnusson wrote on Tue, Jun 21, 2016 at 05:08:16 +0200:
> On Tue, Jun 21, 2016 at 3:53 AM, Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> > The fix is to stop calling chabspath() at the top of chrealpath().
> >
> > Preserve the old behaviour when CHASE_DOTS is set.
> 
> I think this is backwards, cd symlink/.. gets you to the current dir
> if chasedots is unset, and to wherever symlink points' parent
> directory when it is set.

True.

However, I don't want to just flip the condition (change "if isset()" to
"if unset()") since I think the new behaviour (resolving symlinks before
'..' components) should be the default for :A.

So how about adding a new option and having chrealpath() use the new
behaviour if the new option is at its default value, and the old
(':a'-ish) behaviour otherwise?