Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
Date: Tue, 5 Jul 2016 22:07:49 +0000 (UTC)
From: Oliver Kiddle <okiddle@yahoo.co.uk>
Reply-To: Oliver Kiddle <okiddle@yahoo.co.uk>
To:  <zsh-workers@zsh.org>
Message-ID: <812932212.4222957.1467756469555.JavaMail.yahoo@mail.yahoo.com>
Subject: Re: [PATCH] _fc: allow the user to limit the number of events
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
References: <812932212.4222957.1467756469555.JavaMail.yahoo.ref@mail.yahoo.com>

Eric Cook wrote:
> +    zstyle -s ":completion:${curcontext}:history-events" history-events _histno

The actual matches are added with just 'events' as the tag so the tag component of this style should be consistent with that.

I'd also agree that the style should have a more generic name. _dates has a max-matches-length style which does the same thing (apart from also allowing a percentage). You might also consider copying the special _next_tags handling from _dates.

> +++ b/Completion/Linux/Command/_sysstat
> @@ -1,4 +1,4 @@
> -#compdef -P mpstat (|cifs)iostat isag sadf sar pidstat
> +#compdef -P mpstat cifsiostat isag sadf sar pidstat

If you remove the pattern, the -P option is not needed here anymore.

Oliver