Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
From: Bart Schaefer <schaefer@brasslantern.com>
Message-Id: <160710215821.ZM11734@torch.brasslantern.com>
Date: Sun, 10 Jul 2016 21:58:21 -0700
In-Reply-To: <6ED44F4D-7D51-4F0B-935D-4A3868E0C5C3@gmail.com>
Comments: In reply to Zhiming Wang <zmwangx@gmail.com>
        "Re: [BUG] Directory glob picks up running or already-run scripts on OS X" (Jul 11,  8:48am)
References: <CEE58D57-A237-4451-8882-0AE0CE21DD58@gmail.com> 
	<CAH+w=7Y6GEJxa5LS4AeG5V5hsyUYJkSEEEMRnMSSJpLpRfLPXA@mail.gmail.com> 
	<B17666ED-6D14-477C-B45D-3B7F064B5F24@gmail.com> 
	<CAH+w=7Zr8T2b7hMhjj1K0oJ_KaWE2MBAfwBzmKnZzjOfvYjn5Q@mail.gmail.com> 
	<6ED44F4D-7D51-4F0B-935D-4A3868E0C5C3@gmail.com>
To: zsh-workers@zsh.org
Subject: Re: [BUG] Directory glob picks up running or already-run scripts on OS X
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii

I'm not sure whether this was introduced when adding the (Y) qualifier,
or if it was already lurking.  With the following DPUTS() added and zsh
compiled with debugging, Test/D02glob.ztst will fail (on any platform).

diff --git a/Src/glob.c b/Src/glob.c
index 2051016..5260b63 100644
--- a/Src/glob.c
+++ b/Src/glob.c
@@ -318,6 +318,8 @@ insert(char *s, int checked)
     char *news = s;
     int statted = 0;
 
+    DPUTS(!s || !*s, "BUG: adding empty string as glob match");
+
     queue_signals();
     inserts = NULL;
 

The problem seems to be that scanner() calls recursively one extra
time when looking at "notadirectory/".

In that case statfullpath("") is called and, for reasons I haven't
figured out, that returns success on MacOS when called in exactly
the circumstances that Zhiming describes.

This will eventually correct itself, which leads me to suspect it has
something to do with re-using the global static "pathbuf".

The simple fix would be for insert() to be a no-op when called on the
empty string, but it might be useful to examine scanner() in more
detail to try to avoid the extra recursion.