Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Qmail-Scanner-Diagnostics: from hermes.apache.org by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(140.211.11.3):SA:0(-1.3/5.0):. Processed in 0.120123 secs); 13 Jul 2016 05:06:41 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.3 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, RP_MATCHES_RCVD autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: danielsh@apache.org X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at apache.org does not designate permitted sender hosts) Date: Wed, 13 Jul 2016 04:59:57 +0000 From: Daniel Shahaf To: Marko Myllynen Cc: zsh workers Subject: Re: zsh virsh completion Message-ID: <20160713045957.GA3893@tarsus.local2> References: <8eb6dce0-50d7-5ab2-503a-194c1de2e45d@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <8eb6dce0-50d7-5ab2-503a-194c1de2e45d@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Seq: zsh-workers 38840 Marko Myllynen wrote on Mon, Jul 11, 2016 at 14:52:02 +0300: > Below is a patch to implement basic completion for the virsh(1) [1] > command from libvirt [2], it completes all virsh commands and their > respective options. > > I think it's pretty good and hopefully the caching approach is sane (of > course it'd be nice to get rid of that awk call but no biggie). Thanks! Note there are two or three other _virsh's floating around: https://github.com/jplitza/zsh-virsh-autocomplete/blob/master/_virsh https://github.com/zsh-users/zsh-completions/blob/master/src/_virsh https://github.com/Aso23/zsh_virsh_autocompletion/blob/master/_virsh Those seem to have features your patch lacks, e.g., completing domain (VM name) arguments. What can we do about this duplication? Cheers, Daniel