Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Qmail-Scanner-Diagnostics: from mailout4.w1.samsung.com by f.primenet.com.au (envelope-from <p.stephenson@samsung.com>, uid 7791) with qmail-scanner-2.11 
 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1.  
 Clear:RC:0(210.118.77.14):SA:0(-1.3/5.0):. 
 Processed in 0.123368 secs); 18 Jul 2016 08:41:52 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-1.3 required=5.0 tests=RP_MATCHES_RCVD
	autolearn=unavailable autolearn_force=no version=3.4.1
X-Envelope-From: p.stephenson@samsung.com
X-Qmail-Scanner-Mime-Attachments: |
X-Qmail-Scanner-Zip-Files: |
Received-SPF: none (ns1.primenet.com.au: domain at samsung.com does not designate permitted sender hosts)
X-AuditID: cbfec7f5-f792a6d000001302-55-578c964623c9
Date: Mon, 18 Jul 2016 09:41:42 +0100
From: Peter Stephenson <p.stephenson@samsung.com>
To: "zsh-workers@zsh.org" <zsh-workers@zsh.org>
Subject: Re: strptime() on Cygwin requires _XOPEN_SOURCE
Message-id: <20160718094142.57773bc4@pwslap01u.europe.root.pri>
In-reply-to: <AF9EE581-2824-44FB-9D14-90524F6B0FED@kba.biglobe.ne.jp>
References: <AF9EE581-2824-44FB-9D14-90524F6B0FED@kba.biglobe.ne.jp>
Organization: Samsung Cambridge Solution Centre
X-Mailer: Claws Mail 3.7.9 (GTK+ 2.22.0; i386-redhat-linux-gnu)
MIME-version: 1.0
Content-type: text/plain; charset=US-ASCII
Content-transfer-encoding: 7bit
X-Brightmail-Tracker:
 H4sIAAAAAAAAA+NgFrrALMWRmVeSWpSXmKPExsVy+t/xa7pu03rCDZ4uYbU42PyQyYHRY9XB
	D0wBjFFcNimpOZllqUX6dglcGf83phcsYqnYdq+FpYFxC3MXIyeHhICJxJNpjawQtpjEhXvr
	2boYuTiEBJYyStzd8ZIFwpnBJLH7xQJmCOcco8SHic/ZIZyzjBL9GyczgfSzCKhK7Hx7lh3E
	ZhMwlJi6aTYjiC0ioC9x8c8tMFtYwELi8/spYDW8AvYS/S+Xgd3BKeAqcXvxCbA7hARcJL7f
	/wQ2kx+o9+pfCFsCqH7mlTOMEL2CEj8m32MBsZkFtCQ2b2tihbDlJTavecsMMUdd4sbd3ewT
	GIVnIWmZhaRlFpKWBYzMqxhFU0uTC4qT0nON9IoTc4tL89L1kvNzNzFCwvnrDsalx6wOMQpw
	MCrx8N5Y2x0uxJpYVlyZe4hRgoNZSYTXf3JPuBBvSmJlVWpRfnxRaU5q8SFGaQ4WJXHembve
	hwgJpCeWpGanphakFsFkmTg4pRoY6+ovRSs1n93+q/ZObUEQg9GqDfc2Cv946blljYWAjJ5f
	wiKFPM23La0nS5L9Cg1X51lPC639yHfPcsGGFWYr3r56H75bv2/r70eP7GrLp0apPL7XbMAk
	Hpv2+khoduC6XckhuaJf4/i17i/ZsuWxZ8JXGWnBupxyuaMaz613X06ULQ/L++6kxFKckWio
	xVxUnAgAmvTt/GMCAAA=
X-Seq: zsh-workers 38876

On Sat, 16 Jul 2016 14:34:30 +0900
Jun T. <takimoto-j@kba.biglobe.ne.jp> wrote:
> A possible fix is to define _XOPEN_SOURCE in datetime.c (patch1 below).
> Another possibility is to define _GNU_SOURCE in zsh_system.h (patch2).
> 
> Both work OK on the latest Cygwin, but I can't test on older Cygwin.
> Maybe patch1 is better since it would have minimum side effects?

Probably, yes.  It's really hard to work out what effects a change in
the main header is going to do to all the variety of systems, even if
they're GNU based.

pws

