Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
Received-SPF: pass (ns1.primenet.com.au: SPF record at _spf.mail.yahoo.com designates 212.82.97.123 as permitted sender)
cc: zsh-workers@zsh.org
In-reply-to: <699166a0-b0f0-452c-2561-b7e3cc952062@redhat.com>
From: Oliver Kiddle <okiddle@yahoo.co.uk>
References: <8eb6dce0-50d7-5ab2-503a-194c1de2e45d@redhat.com> <20160713045957.GA3893@tarsus.local2> <9968da53-c1fd-fa2a-f30c-c74f884d2478@redhat.com> <20160720065832.GA28939@tarsus.local2> <699166a0-b0f0-452c-2561-b7e3cc952062@redhat.com>
To: Marko Myllynen <myllynen@redhat.com>
Subject: Re: [PATCH] _virsh (Was: Re: zsh virsh completion)
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <25000.1469117569.1@hydra.kiddle.eu>
Date: Thu, 21 Jul 2016 18:12:49 +0200
Message-ID: <25001.1469117569@hydra.kiddle.eu>

Marko Myllynen wrote:
> +      _values servers ${=${(S)${${(f)$(sudo virt-admin srv-list)}##*--- }//[0-9]* }} && return 0

> +      _values servers ${=${${(f):-"$(sudo virt-admin srv-clients-list --server $srv)"}/ [a-z]*}//[^0-9]} && return 0

I have pushed the change but I've just noticed these two lines. I'm not
sure it is a good idea to be running sudo within completion functions.
That can trigger logging and is often denied when you're already root.
And there may be alternatives like doas.

There's also another instance of this in Mandriva/Command/_rebootin.

Anyone, have any thoughts on how this should be handled? I'm inclined
to think that users should have to specifically set a gain-root
style to enable this. Or perhaps it could only trigger if you
complete after sudo virt-admin.

Oliver