Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
Received-SPF: none (ns1.primenet.com.au: domain at brasslantern.com does not designate permitted sender hosts)
From: Bart Schaefer <schaefer@brasslantern.com>
Message-Id: <160721173805.ZM31148@torch.brasslantern.com>
Date: Thu, 21 Jul 2016 17:38:05 -0700
In-Reply-To: <20160720093515.07cedcdc@pwslap01u.europe.root.pri>
Comments: In reply to Peter Stephenson <p.stephenson@samsung.com>
        "Re: Incorrect sorting of Polish characters" (Jul 20,  9:35am)
References: <CAJzQX7rXddxjFA2reSiGYHpU9Razo2vwO5F5g-4Ddz-ZjXZsUQ@mail.gmail.com> 
	<160716130718.ZM4513@torch.brasslantern.com> 
	<20160718103329.7acbb1b1@pwslap01u.europe.root.pri> 
	<20160718111735.6adea125@pwslap01u.europe.root.pri> 
	<160719220508.ZM10438@torch.brasslantern.com> 
	<20160720093515.07cedcdc@pwslap01u.europe.root.pri>
To: zsh-workers@zsh.org
Subject: Re: Incorrect sorting of Polish characters
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii

On Jul 20,  9:35am, Peter Stephenson wrote:
} Subject: Re: Incorrect sorting of Polish characters
}
} On Tue, 19 Jul 2016 22:05:08 -0700
} Bart Schaefer <schaefer@brasslantern.com> wrote:
} > Hm.  On a glob of 16794 files it's about 4% slower over 10 trials with
} > the extra pass over the array of matches.  I don't suppose there's some
} > way to store the original file name at the time metafication is applied
} > rather than metafying and then unmetafying again?
} 
} It already works like that, and it only copies and unmetafies if there's
} a Meta character.

What I meant was (now that I have poked around a bit further), maybe
zreaddir() should be able to return unmetatfied strings on request,
which scanner() could then metafy before calling pattry() and when a
match is found, pass both to insert() ?

Seems wasteful for zreaddir() to unconditionally metafy when the
caller may need the name unmetafied.  However, this does mean passing
both strings through a lot of layers, so maybe not worth it for 4%.

The strchr() does shave it down a fraction.