Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Qmail-Scanner-Diagnostics: from hermes.apache.org by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(140.211.11.3):SA:0(-1.3/5.0):. Processed in 0.118289 secs); 23 Jul 2016 18:03:24 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.3 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, RP_MATCHES_RCVD autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: danielsh@apache.org X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at apache.org does not designate permitted sender hosts) Date: Sat, 23 Jul 2016 18:03:16 +0000 From: Daniel Shahaf To: Oliver Kiddle Cc: zsh-workers@zsh.org Subject: Re: [PATCH v2] Re: [PATCH] _add-zle-hook-widget: New completion. Message-ID: <20160723180316.GA4593@tarsus.local2> References: <160716185103.ZM5258@torch.brasslantern.com> <1468767614-9635-1-git-send-email-danielsh@tarsus.local2> <91351.1468835277@hydra.kiddle.eu> <20160720065421.GE28939@tarsus.local2> <22468.1469114906@hydra.kiddle.eu> <20160722062259.GB3457@tarsus.local2> <87043.1469213140@hydra.kiddle.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <87043.1469213140@hydra.kiddle.eu> User-Agent: Mutt/1.5.23 (2014-03-12) X-Seq: zsh-workers 38924 Oliver Kiddle wrote on Fri, Jul 22, 2016 at 20:45:40 +0200: > > > Furthermore, while checking that this wasn't intentional I noticed > > > a couple of functions that use _normal where _default was meant. > > > > _default appears to be undocumented. > > Actually it sort of is documented: the section on special contexts which > mentions -default- and says that default implementations exist named > _context. Ah, I missed those since I just grepped zshall for /_default/. > Should there perhaps be findex entries there for each context? This would make a search for /_default/ succeed in the pdf/html rendering, but won't affect the man page rendering. I'm not sure what we can do for the man page version, short of enumerating all the _foo, _bar, _baz names in the running text right after the enumeration of -foo-, -bar-, -baz- names. > Thinking about it, perhaps the original intention was that _dispatch > should be used but direct calls to _default are widespread and date > back to early times. How about the following. I'm not sufficiently familiar with this corner of compsys to be able to review the diff for completeness, but thanks for writing it. Cheers, Daniel