Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
Received-SPF: pass (ns1.primenet.com.au: SPF record at _spf.mail.yahoo.com designates 212.82.97.45 as permitted sender)
In-reply-to: <20160723212345.GA2982@tarsus.local2>
From: Oliver Kiddle <okiddle@yahoo.co.uk>
References: <20160723180430.GA22451@tarsus.local2> <160723130059.ZM19333@torch.brasslantern.com> <20160723212345.GA2982@tarsus.local2>
To: zsh-workers@zsh.org
Subject: Re: [PATCH] _describe and literal \n
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <5529.1469316428.1@hydra.kiddle.eu>
Date: Sun, 24 Jul 2016 01:27:08 +0200
Message-ID: <5530.1469316428@hydra.kiddle.eu>

Daniel Shahaf wrote:
> I haven't been able to get menu selection's highlighting to misbehave.
>
> However, consider this:
>
> Current master:
>     % _f() { a=( $'foo:hello\nworld' $'bar:lorem\nipsum' $'baz:lorem\nipsum' ); _describe descr a }
>     % f <TAB>
>     baz  
>     foo  -- lorem\nipsum
>     bar  -- hello\nworld

Is your fix to the internals of _describe or the more general code.
Note that _describe truncates descriptions but by using compadd -ld, you
can have multiline descriptions and it works well. fc completion often
contains newlines and I've never had issues with it. However, I think
the intention in _describe was to not have newlines.

I'm not especially fond of the \n escapes. Would prefer they were mapped
to spaces. However, failing to group baz and foo is clearly wrong.

It could be worth experimenting with long strings that approach the
right edge of the terminal to see if it is affecting the calculations.

Oliver