Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
Received-SPF: none (ns1.primenet.com.au: domain at brasslantern.com does not designate permitted sender hosts)
MIME-Version: 1.0
In-Reply-To: <1469884317-3192-1-git-send-email-danielsh@tarsus.local2>
References: <1469884317-3192-1-git-send-email-danielsh@tarsus.local2>
From: Bart Schaefer <schaefer@brasslantern.com>
Date: Sat, 30 Jul 2016 07:40:08 -0700
Message-ID: <CAH+w=7a-OvaCh7qriz86kSXEKj7v5xHoWcKnJVdC56f_VgPjJw@mail.gmail.com>
Subject: Re: [PATCH] _widgets: Complete zle-* widgets too.
To: Daniel Shahaf <d.s@daniel.shahaf.name>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Content-Type: multipart/alternative; boundary=001a1141292efed0b60538db5763

--001a1141292efed0b60538db5763
Content-Type: text/plain; charset=UTF-8

I don't think this is right.  Those names should be completed only if they
have already been created with "zle -N", and it is not appropriate to
autoload add-zle-hook-widget in the generic widgets completion function.

On Jul 30, 2016 8:13 AM, "Daniel Shahaf" <d.s@daniel.shahaf.name> wrote:

> ---
>  Completion/Zsh/Type/_widgets | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/Completion/Zsh/Type/_widgets b/Completion/Zsh/Type/_widgets
> index fdab281..0e7f491 100644
> --- a/Completion/Zsh/Type/_widgets
> +++ b/Completion/Zsh/Type/_widgets
> @@ -2,8 +2,14 @@
>
>  local expl pattern
>
> +local -a fake
> +autoload -U add-zle-hook-widget
> +add-zle-hook-widget -h >&/dev/null # sets the zstyle
> +zstyle -g fake zle-hook types
> +fake=( zle-${^fake} )
> +
>  pattern=( -g \* )
>  zparseopts -D -K -E g:=pattern
>
>  _description widgets expl widget
> -compadd "$@" "$expl[@]" -M 'r:|-=* r:|=*' -
> "${(@k)widgets[(R)${pattern[2]}]}"
> +compadd "$@" "$expl[@]" -M 'r:|-=* r:|=*' -
> "${(@k)widgets[(R)${pattern[2]}]}" "${(@M)fake:#${~pattern[2]}}"
>

--001a1141292efed0b60538db5763--