Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Qmail-Scanner-Diagnostics: from out5-smtp.messagingengine.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(66.111.4.29):SA:0(0.0/5.0):. Processed in 0.104024 secs); 01 Aug 2016 21:41:24 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.1 X-Envelope-From: d.s@daniel.shahaf.name X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at daniel.shahaf.name does not designate permitted sender hosts) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= daniel.shahaf.name; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-sasl-enc :x-sasl-enc; s=mesmtp; bh=b0TvRiYm/vG50u9LkDP9N4QBIKg=; b=14n8sH bXZ/8wwxKbBkkpBJZPwt/5SPDx9mgZtAffjtpJdogQPvoFsP2WkoVFbmCjImyqoL 1NHVdFugB33jI/lK1AuH3RtaQ8/AATPnd/BEbZmrW0UoWaad58s9AA3VoWnZh6gD hzRGWcz69VBXUMnEVtNGMrFJmRuu7NmpDDY08= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-sasl-enc :x-sasl-enc; s=smtpout; bh=b0TvRiYm/vG50u9LkDP9N4QBIKg=; b=VoZDg +duaqdcCFO0N/JEkWrDjZYN19X0Jg+MLG4dDdbFWFi5fJazaIUlVnrdWHQAcBvl6 S2KnOL85qUznqyOMb4pBMEmXEqCxAh9eOhRenBGkU1FrmCq+ZZuPVaszWzGAI6bf X4lH064TLQuSb4qW4QahCTVGY6JZJGC94/K5qE= X-Sasl-enc: 0OgWEGLpvQ0d/fm7Ao/LqHoVLyR1kpLZnSrzlknoGjJ6 1470087675 Date: Mon, 1 Aug 2016 21:41:09 +0000 From: Daniel Shahaf To: Oliver Kiddle Cc: Andy Spencer , zsh-workers@zsh.org Subject: Re: [PATCH] Add completion for cpupower command Message-ID: <20160801214109.GD2838@tarsus.local2> References: <20160731110516.GA20521@pileus.org> <16722.1470082775@hydra.kiddle.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <16722.1470082775@hydra.kiddle.eu> User-Agent: Mutt/1.5.21 (2010-09-15) X-Seq: zsh-workers 38987 Oliver Kiddle wrote on Mon, Aug 01, 2016 at 22:19:35 +0200: > Andy Spencer wrote: > > + '(-f --freq)'{-f,--freq}'[new frequency for userspace governor]:freq->freq' > > There's a colon missing on that line. Should it be {-f+,--freq=}? That is, can the argument be in the same word as the option? The part after the first colon is in this function abbreviated ("freq", "secs", etc); don't we usually prefer full noun phrases ("frequency", "interval (seconds)", etc)? Oliver's review addresses all the other points I noticed (and a few that I didn't). Cheers, Daniel