Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Qmail-Scanner-Diagnostics: from mailout3.w1.samsung.com by f.primenet.com.au (envelope-from <p.stephenson@samsung.com>, uid 7791) with qmail-scanner-2.11 
 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1.  
 Clear:RC:0(210.118.77.13):SA:0(-0.5/5.0):. 
 Processed in 0.143002 secs); 09 Aug 2016 08:50:26 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-0.5 required=5.0 tests=RP_MATCHES_RCVD
	autolearn=unavailable autolearn_force=no version=3.4.1
X-Envelope-From: p.stephenson@samsung.com
X-Qmail-Scanner-Mime-Attachments: |
X-Qmail-Scanner-Zip-Files: |
Received-SPF: none (ns1.primenet.com.au: domain at samsung.com does not designate permitted sender hosts)
X-AuditID: cbfec7f4-f796c6d000001486-5a-57a996f030fd
Date: Tue, 09 Aug 2016 09:40:13 +0100
From: Peter Stephenson <p.stephenson@samsung.com>
To: zsh-workers@zsh.org
Subject: Re: [bug] shwordsplit not working on $@ when $# > 1
Message-id: <20160809094013.01f0f5f8@pwslap01u.europe.root.pri>
In-reply-to: <160808182124.ZM9355@torch.brasslantern.com>
References: <20160808111626.GA19766@chaz.gmail.com>
 <20160808192734.21923640@ntlworld.com>
 <160808182124.ZM9355@torch.brasslantern.com>
Organization: Samsung Cambridge Solution Centre
X-Mailer: Claws Mail 3.7.9 (GTK+ 2.22.0; i386-redhat-linux-gnu)
MIME-version: 1.0
Content-type: text/plain; charset=US-ASCII
Content-transfer-encoding: 7bit
X-Brightmail-Tracker:
 H4sIAAAAAAAAA+NgFjrPLMWRmVeSWpSXmKPExsVy+t/xK7ofpq0MN+g/pGBxsPkhkwOjx6qD
	H5gCGKO4bFJSczLLUov07RK4Mn6tf8dasJq9YsKt70wNjM9Zuxg5OSQETCQmbGtggrDFJC7c
	W8/WxcjFISSwlFFixfTT7BDODCaJQw9/gHUICZxmlDi9WQEicYZRonHacTaQBIuAqsSpqU3M
	IDabgKHE1E2zGUFsEQFxibNrz7OA2MICNhJd5+aBxXkF7CUW7uoE2sDBwSlgKfFzCjPE/G5G
	iVXXS0FsfgF9iat/P0FdZy8x88oZqFZBiR+T74GNZBbQkti8rYkVwpaX2LzmLdQcdYkbd3ez
	T2AUnoWkZRaSlllIWhYwMq9iFE0tTS4oTkrPNdQrTswtLs1L10vOz93ECAnmLzsYFx+zOsQo
	wMGoxMN7YfmKcCHWxLLiytxDjBIczEoivM8mrgwX4k1JrKxKLcqPLyrNSS0+xCjNwaIkzjt3
	1/sQIYH0xJLU7NTUgtQimCwTB6dUA+NEwaTtFvM+J65fdGxl4ZKIlt7/v/z3VFwKSPBWjzi9
	4kPVxcaPi1deD9b3i3/4+pfPWgOPu4qqnl1CyvLaOb3ru6tcxbd/uD1Hn4dl/svUuQe6ilJy
	2SYpbXA8Yyj+6lfwx4w30++V2W3TdGV36vzTI/jmZWG1ZXIoX/UCrXWaj6Vlpi0780aJpTgj
	0VCLuag4EQAO008WYgIAAA==
X-Seq: zsh-workers 39011

On Mon, 08 Aug 2016 18:21:24 -0700
Bart Schaefer <schaefer@brasslantern.com> wrote:
> I *think* we can untangle this as follows, but then again I thought
> I had untangled in in workers/29313, too.  This relies on the idea
> that if we already have an array when nojoin, then we're not going
> to split it again, which seems dubious somehow if there is explicit
> use of the (s:-:) flag.

That was my first worry, looking at the change, but simple examples of
this still work, so I can't see an obvious case where this isn't better
than before.

> Existing tests still pass, but then they always did, this needs a
> new one.  Holding off until we think of other edge cases.

I suppose adding tests is key to this.  There are already a number
involving (s...), however.  Perhaps we need some more with both joining
and splitting on various types of object (and then work out what the
result actually should be...)

pws

