Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
Received-SPF: none (ns1.primenet.com.au: domain at brasslantern.com does not designate permitted sender hosts)
From: Bart Schaefer <schaefer@brasslantern.com>
Message-Id: <160812160407.ZM30052@torch.brasslantern.com>
Date: Fri, 12 Aug 2016 16:04:07 -0700
In-Reply-To: <DC080C9F-3A3D-4B68-BE29-765F7898647F@larryv.me>
Comments: In reply to Lawrence Velazquez <vq@larryv.me>
        "${#${(A)=name=word}} behavior depends on number of elements" (Aug 12,  6:11pm)
References: <DC080C9F-3A3D-4B68-BE29-765F7898647F@larryv.me>
To: zsh-workers@zsh.org
Subject: Re: ${#${(A)=name=word}} behavior depends on number of elements
Cc: Lawrence Velazquez <vq@larryv.me>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii

On Aug 12,  6:11pm, Lawrence Velazquez wrote:
} Subject: ${#${(A)=name=word}} behavior depends on number of elements
}
} As I would expect, ${#${(A)=name=word}} expands to the number of
} elements in array "foo" after assignment.
} 
} However, if "foo" ends up with just one element, the expression expands
} to the number of characters in that element.

The value of ${foo=right-hand-side} is the value of right-hand-side,
after applying all the expansion flags, not the value of $foo.  Thus
${#...} counts right-hand-side, and the shwordsplit of a word with no
spaces is a scalar, not an array, so the number of characters results.

However, this turns out to be ridiculously easy to change so that
the code matches the implication of the doc for ${NAME=WORD}.


diff --git a/Src/subst.c b/Src/subst.c
index 99e1650..c61551b 100644
--- a/Src/subst.c
+++ b/Src/subst.c
@@ -2897,6 +2897,7 @@ paramsubst(LinkList l, LinkNode n, char **str, int qt, int pf_flags,
 			    aval = paramvalarr(pm->gsu.h->getfn(pm), hkeys|hvals);
 		    } else
 			setaparam(idbeg, a);
+		    isarr = 1;
 		} else {
 		    untokenize(val);
 		    setsparam(idbeg, ztrdup(val));
diff --git a/Test/D04parameter.ztst b/Test/D04parameter.ztst
index 460a841..37166fa 100644
--- a/Test/D04parameter.ztst
+++ b/Test/D04parameter.ztst
@@ -82,6 +82,11 @@
 >wasnull2d
 >wasnull2d
 
+  unset array
+  print ${#${(A)=array=word}}
+0:${#${(A)=array=word}} counts array elements
+>1
+
   (print ${set1:?okhere}; print ${unset1:?exiting1}; print not reached;)
   (print ${null1?okhere}; print ${null1:?exiting2}; print not reached;)
 1:${...:?...}, ${...?...}