Subject: Re: [PATCH] New :P history modifier.
From: Daniel Shahaf <[email-masked]>
To: [email-masked]
Date: Thu, 18 Aug 2016 16:55:41 +0000
List-Id: Zsh Workers List <zsh-workers.zsh.org>

Bart Schaefer wrote on Wed, Aug 17, 2016 at 10:06:14 -0700:
> On Aug 17,  4:31pm, Daniel Shahaf wrote:
> }
> } - xsymlink() is not a drop-in replacement: it tolerates trailing
> }   non-existing path components.  The single callsite in current master
> }   wouldn't care, though.
> 
> Pretty much my point; if there's only one call and they're equivalent
> for that instance, why leave the special case?

*nod*

> } >  The new word modifier ':P' computes the physical path of the argument.
> } >  it is different from the existing ':a' modifier which does always
> } >  resolves /before/here/../after to /before/after, and differs from the
> } >  existing ':A' modifier which resolves symlinks only after here/.. is
> } >  removed even when /before/here is itself a symbolic link.
> } 
> } What about the "It is recommended [to audit uses of :A and change them
> } to :P]" sentence that the original patch had, should it be kept or
> } removed?
> 
> IMO it can be kept.

Kept.  The interdiff so far follows.

Thanks again for the review,

Daniel

diff --git a/Completion/Zsh/Type/_history_modifiers b/Completion/Zsh/Type/_history_modifiers
index 5141d80..1a049d6 100644
--- a/Completion/Zsh/Type/_history_modifiers
+++ b/Completion/Zsh/Type/_history_modifiers
@@ -64,8 +64,8 @@ while true; do
       )
     if (( ! global )); then
       list+=(
-	"a:absolute path, resolve '..' logically"
-	"A:same, then resolve symlinks"
+	"a:absolute path, resolve '..' lexically"
+	"A:as ':a', then resolve symlinks"
 	"c:PATH search for command"
 	"g:globally apply s or &"
 	"h:head - strip trailing path element"
diff --git a/NEWS b/NEWS
index d676e40..65b246d 100644
--- a/NEWS
+++ b/NEWS
@@ -7,13 +7,13 @@ Note also the list of incompatibilities in the README file.
 Changes from 5.2 to 5.3
 -----------------------
 
-The new word modifier ':P' computes the realpath() of the argument.
-It is different from the existing ':a' modifier which does not resolve
-symlinks, and from the existing ':A' modifier which always resolves
-/before/here/../after to /before/after --- even if /before/here is
-a symbolic link.  It is recommended to review uses of ':A' and, if
-appropriate, convert them to ':P' as soon as compatibility with 5.2 is
-no longer a requirement.
+The new word modifier ':P' computes the physical path of the argument.
+It is different from the existing ':a' modifier which always resolves
+'/before/here/../after' to '/before/after', and differs from the
+existing ':A' modifier which resolves symlinks only after 'here/..' is
+removed, even when /before/here is itself a symbolic link.  It is
+recommended to review uses of ':A' and, if appropriate, convert them
+to ':P' as soon as compatibility with 5.2 is no longer a requirement.
 
 Changes from 5.1.1 to 5.2
 -------------------------