Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.220.182 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <70414.1471625341@hydra.kiddle.eu>
References: <70414.1471625341@hydra.kiddle.eu>
From: Mikael Magnusson <mikachu@gmail.com>
Date: Sat, 20 Aug 2016 00:46:38 +0200
Message-ID: <CAHYJk3R4zYYePLbwLU265K2HzZdtD8-T1_MLh6FPHv5PBsNVEw@mail.gmail.com>
Subject: Re: PATCH: minor git completion tweaks
To: Oliver Kiddle <okiddle@yahoo.co.uk>
Cc: Zsh workers <zsh-workers@zsh.org>
Content-Type: text/plain; charset=UTF-8

On Fri, Aug 19, 2016 at 6:49 PM, Oliver Kiddle <okiddle@yahoo.co.uk> wrote:
> This is just a few minor tweaks that were suggested off-list following
> last week's patch.
>
> Oliver
>
> diff --git a/Completion/Unix/Command/_git b/Completion/Unix/Command/_git
> index ac4c90e..f4011aa 100644
> --- a/Completion/Unix/Command/_git
> +++ b/Completion/Unix/Command/_git
> @@ -249,11 +249,7 @@ _git-bisect () {
>                ;;
>            esac
>            ;;
> -        (${(j.|.)~good})
> -          _arguments \
> -            ': :__git_commits' && ret=0
> -          ;;
> -        (${(j.|.)~good}|skip)
> +        (${(j.|.)~bad}|${(j.|.)~good}|skip)
>            # TODO: skip can take revlists.
>            _arguments \
>              '*: :__git_commits' && ret=0

Could this be (~j.|.) instead? Just in case someone defines good/bad
terms with a pattern character in them :). Also, should it be "git
bisect terms" above this, rather than just "git terms"? I only have
the former, on git 2.8.xyz.

-- 
Mikael Magnusson