Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
Received-SPF: none (ns1.primenet.com.au: domain at daniel.shahaf.name does not designate permitted sender hosts)
Date: Sat, 20 Aug 2016 03:07:38 +0000
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Stefano Balzan <stefano.balzan@gmail.com>
Cc: zsh-workers@zsh.org
Subject: Re: Zsh Completion - Bug report
Message-ID: <20160820030738.GA15743@fujitsu.shahaf.local2>
References: <CAEimH9D2Nu1b7s2EHWkBM1EAtJyREHMMjcFod_1OCXsJD=ke6g@mail.gmail.com>
 <20160819155829.GA3389@fujitsu.shahaf.local2>
 <20160819172605.GG3597@sym.noone.org>
 <CAEimH9Ad+iraRCTnpFBOzrCv5gf=3cnJ=pspDFCSL1UMNakSbg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAEimH9Ad+iraRCTnpFBOzrCv5gf=3cnJ=pspDFCSL1UMNakSbg@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)

Stefano Balzan wrote on Fri, Aug 19, 2016 at 20:03:50 +0200:
> Thank you, I think your fix should do, pay attention to the typo Axel
> pointed out though.

Pushed with the correction — thanks everyone for the reviews.

> I'm no expert of the 'ip' command, anyway this is how I would add an arp
> entry:
> 
>  "ip neigh add 192.168.1.1 lladdr 12:34:56:78:ab:cd [other parameters]"
> 
> Probably the lladdr keyword (link layer address) should be suggested at
> argv[4], but I'm not completely sure.

Thanks for the example.  Currently, argv[4] in your command is completed
correctly but argv[3] completes as argv[4]; that is: completing argv[3]
offers lladdr and doesn't offer "an IP address".

It's probably not hard to fix, but I'll leave it to someone else...

Cheers,

Daniel