Zsh Mailing List Archive
Messages sorted by:
Re: _man completion update for Solaris
- X-seq: zsh-workers 39201
- From: Danek Duvall <duvall@xxxxxxxxxxxxxx>
- To: Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx>
- Subject: Re: _man completion update for Solaris
- Date: Tue, 6 Sep 2016 18:11:50 -0700
- Cc: zsh-workers@xxxxxxx
- In-reply-to: <20160906224508.GB4800@fujitsu.shahaf.local2>
- List-help: <mailto:firstname.lastname@example.org>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:email@example.com>
- Mail-followup-to: Danek Duvall <duvall@xxxxxxxxxxxxxx>, Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx>, zsh-workers@xxxxxxx
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
- References: <20160906180614.GB23101@lorien.comfychair.org> <20160906224508.GB4800@fujitsu.shahaf.local2>
On Tue, Sep 06, 2016 at 10:45:08PM +0000, Daniel Shahaf wrote:
> Danek Duvall wrote on Tue, Sep 06, 2016 at 11:06:14 -0700:
> > After finally looking at Daniel's _man changes, I saw that there were a
> > couple of small (pre-existing) issues on Solaris.
> Thanks for the review.
> > Namely: the -s option can take a comma-separated list of sections; and
> > the man-index directory gets thrown into the mix when it shouldn't.
> > This patch takes care of those two things.
> Thanks. The patch looks good to me. I'll push it tomorrow (not right
> now to give others a chance to respond).
> > I don't know if the comma/colon section separation should just be generic
> > -- it's safe to do on Solaris, since although we don't recognize the
> > separator, we don't have any sections that have colons in them -- but I
> > don't know if it's compatible with the third if clause there.
> "Third if clause" refers to what? If you mean the 'else' branch just
> below the context of the first hunk, then on my system «man 7,8 foo»
> looks for a section literally called "man7,8" whereas the same with -S
> looks in the "man7" and "man8" sections, so at least on my system the
> 'else" branch shouldn't s/,/|/. (My system runs Debian stable.)
"elif (( CURRENT > 2 ))", but the behavior you describe is the one I was
Messages sorted by: