Zsh Mailing List Archive
Messages sorted by:
Re: [PATCH] Fix ENV handling in sh/ksh emulation
- X-seq: zsh-workers 39225
- From: Teubel György <tgyurci@xxxxxxxxx>
- To: zsh-workers@xxxxxxx
- Subject: Re: [PATCH] Fix ENV handling in sh/ksh emulation
- Date: Wed, 7 Sep 2016 11:10:15 +0200
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ofJWM9q/Olq+BFSulxZ/lu+8cNr0CVLO0y2kPifxP4c=; b=U/LE6L1kHnQqCvepySI/Qy1MifIjM4p3bM5bz1+5SvCXltsh+M7T4FeRH7MmGw4Hvp qEFznq2ZAhZdP/xljWu4wXlUuew1O51DJ2CScw5fLLs4h6y3QM9odgSuokKvMklI+HtB gYM4+3CWpeBv/CLfW8XcgVZXFijq/xU+herQp9xGjLufXRt48dkzl2hAQFu6xf68WPvp vIthPpxyFiptXhDMNXfaLqQB/kSyFOJGIqD+W8Kiy7GqOe79p/yoUBAWBGVQ0uh9F90b YiOZh/4cdspMVfglt10IZ/bQGHq1q/LnUcbLDGp9QgN73g+Rp8s47zkC2GQB8p7i6hOS +QFg==
- In-reply-to: <160906225736.ZM11304@torch.brasslantern.com>
- List-help: <mailto:firstname.lastname@example.org>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:email@example.com>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
- References: <firstname.lastname@example.org> <160906225736.ZM11304@torch.brasslantern.com>
On Tue, Sep 06, 2016 at 10:57:36PM -0700, Bart Schaefer wrote:
> Aside that this patch also included two other hunks changing
> isset(INTERACTIVE) to the equivalent "interact" macro instead.
Sorry for forgetting to mention it :(
I thought that it would be somewhat related to the patch.
> This makes them all the same in init.c, except for one use of
> unset(INTERACTIVE) instead of !interact. However, other files
> don't seem to be consistent about making use of this macro,
> nor even about whether unset() vs. !isset() is chosen.
> I'm not suggesting we go to any special effort to clean this up,
> but I'd rather not sneak this kind of thing into unrelated diffs
> (at least, not without mentioning it) because, along with things
> like whitespace clean-up, it makes it difficult to tell from a
> delta what changes are semantically meaningful.
Messages sorted by: