Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH] Fix ENV handling in sh/ksh emulation

On Tue, Sep 06, 2016 at 10:57:36PM -0700, Bart Schaefer wrote:
> Aside that this patch also included two other hunks changing
> isset(INTERACTIVE) to the equivalent "interact" macro instead.

Sorry for forgetting to mention it :(                                                                                                                 
I thought that it would be somewhat related to the patch.

> This makes them all the same in init.c, except for one use of
> unset(INTERACTIVE) instead of !interact.  However, other files
> don't seem to be consistent about making use of this macro,
> nor even about whether unset() vs. !isset() is chosen.
> I'm not suggesting we go to any special effort to clean this up,
> but I'd rather not sneak this kind of thing into unrelated diffs
> (at least, not without mentioning it) because, along with things
> like whitespace clean-up, it makes it difficult to tell from a
> delta what changes are semantically meaningful.

Messages sorted by: Reverse Date, Date, Thread, Author