Zsh Mailing List Archive
Messages sorted by:
Re: [PATCH] internal: quotestring: Drop the 'e' parameter, which no caller uses.
- X-seq: zsh-workers 39265
- From: Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>
- To: zsh-workers@xxxxxxx
- Subject: Re: [PATCH] internal: quotestring: Drop the 'e' parameter, which no caller uses.
- Date: Fri, 9 Sep 2016 22:00:03 -0700
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20150623.gappssmtp.com; s=20150623; h=from:message-id:date:in-reply-to:comments:references:to:subject :mime-version; bh=LJkWgCzUw8HU1p+cOc4lBmZhiHzHA0oeoc+u41mxh6E=; b=LNrqOHwglwm8Rk9wSOwg1tAElyeoELUnFhvF/kF/nXk4q+vssb8DfQ1jkogpA6qnTu Scqn4DwOJXJ6I36/GpRpCwPAHoUzucv89abA+P4d4u9UpTv8TlzFFCaKtxj2YzFK2lMH /e9M1fYxm16+VEO9TtJBg9yztF0XQ/4cE52bTVPzyT851aReJvngDWJg5RCDDQbLGq5z xSSO7X+wwtKFfJ3hiGO2KnC8ecQc++NzGZjE5O6BpA77gMnb3tStVlwxpPwgswGCiONr yhA9PHRHwO4GQeVnQ5+TeUT2n9/sdK+IPWeC3dZT9jRd12ZSiVAGFRSN4j4tUZ/d+CdH EqGA==
- In-reply-to: <email@example.com>
- List-help: <mailto:firstname.lastname@example.org>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:email@example.com>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
- References: <firstname.lastname@example.org>
On Sep 9, 9:38am, Daniel Shahaf wrote:
} Subject: [PATCH] internal: quotestring: Drop the 'e' parameter, which no c
} - * If e is non-zero, the
} - * pointer it points to may point to a position in s and in e the position
} - * of the corresponding character in the quoted string is returned.
Hrm ... this has to have been used at one point e.g. by completion
to keep track of the cursor position while wrapping a substring in
quotes. I wonder when that stopped being necessary.
Found a use in addmatch() back in zsh-2.4 which persists through 3.0.8
but is gone by 4.3. Looks like uses started disappearing after 3.1.5
around about workers/5959 in mid-1999. (The git import from CVS gets
very confused by CVS branches when you go that far back.)
Recall what I've said in a couple of other threads about it being too
hard for completion to intuit what a user means to have remain quoted
and what he expects completion to expand or otherwise treat as unquoted?
The need for this "e" argument seems to have gone away when we decided
to give up and do minimal quote interpretation/insertion.
I don't know what this patch accomplishes other than some dead code
removal, but I guess there's no remaining reason not to commit it.
Messages sorted by: