Re: [PATCH} define _GNU_SOURCE on Cygwin

[Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx>]

Peter A. Castro wrote on Wed, Oct 26, 2016 at 12:55:36 -0700:
> On Wed, 26 Oct 2016, Jun T. wrote:
> >Unless someone still has older cygwin can test the patch, what we
> >can do would be to either go with _GNU_SOURCE (and to see whether
> >incompatibility with older cygwin comes out or not), or just
> >continue using the current code, which generates some warnings
> >but still seems to work fine (the return value of wcwidth() is int,
> >which is what compiler assumes when no prototype is available).
> 
> I'll see if I can give it a quick build and let you know.

Thanks, Peter.

I wasn't meaning to cause the two of you extra work; I had assumed
defining both _XOPEN_SOURCE and _GNU_SOURCE would work on both old and
new cygwin.  I.e., just adding _GNU_SOURCE without removing
_XOPEN_SOURCE.

Cheers,

Daniel