Zsh Mailing List Archive
Messages sorted by:
Re: Valgrind testing, ideas
- X-seq: zsh-workers 41161
- From: Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>
- To: Sebastian Gniazdowski <psprint@xxxxxxxxxxx>
- Subject: Re: Valgrind testing, ideas
- Date: Thu, 25 May 2017 22:50:25 -0700
- Cc: "zsh-workers@xxxxxxx" <zsh-workers@xxxxxxx>
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=O/T0hm/+1KgCmBp4X0Sq9LpEfaNgqnSpFwvdGY06l8Y=; b=GmXUaDy3PJzXINsoQrVdYdfqiNf/NYlI8hDYLXW+HGWZ/WAlyY7t7uvBaPtJ3eYU6P mZfgkDF6WienHgV6TS/Z1irTcOPFdpIqq3UF5a8KWacLJCT9FsUOlBYnMxEwZWeovkRF 7RF4qgwbDF1i1386q/xWAzn13+7hg18/UlZo0RxaYjya46SyoRVH+SUC2YKHtL9yUSeV 4J7OKxuD9UA9krD9JypEnItlQCrEr3Mw3UzDm0L62XhR/csqlzvJ5jX+b/F0nJ/ncZwe +Pmw9EmArWRt9fUEyc71v+u6fy55K98O6koJfgLz3rvvucHjCL0FjxDzgov6oBZjfQwO 2peg==
- In-reply-to: <etPan.5927b758.12200854.1a9@MacMini.local>
- List-help: <mailto:firstname.lastname@example.org>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:email@example.com>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
- References: <etPan.5927b758.12200854.1a9@MacMini.local>
On Thu, May 25, 2017 at 10:04 PM, Sebastian Gniazdowski
> The arrlen branch seems to faint.
Sorry, what's the "arrlen branch"?
> Also I get multiple PIDs from valgrind.
Not all tests use the single zsh. Some explicitly re-invoke
$ZTST_exe, others run in subshells. In fact when I want to add
valgrind to a "make check", I insert
local ZTST_exe=(valgrind $ZTST_exe)
> Last thing, there should be much more test files. Single test per-file, I think.
I'm not thrilled with this suggestion. There are a lot of tests that
depend on sharing a single %prep (and corresponding %cleanup) section,
for example, and also a number of tests that depend on cascading one
after the other. The amount of duplicated code that would result from
attempting to make these into singleton files would lead to other
Messages sorted by: