Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

pull requests for completion functions

I have tentatively added a short line to the bottom of the contributing
section of the web pages to indicate that completions are acceptable in
the form of pull/merge requests. The link is here:


Can I take silence to mean that people were happy with my suggestion on
this new policy? If not then please speak now, reverting the web page is
easily done.

My intended procedure for managing pull requests is as follows.

First you need to add separate remote repositories:
  git remote add gitlab https://gitlab.com/zsh-org/zsh.git
  git remote add github https://github.com/zsh-users/zsh.git

There's a variety of ways to fetch pull requests directly but I add a line
in .git/config under each section:

  under: [remote "gitlab"]
  add:       fetch = +refs/merge-requests/*/head:refs/remotes/gitlab/merge-requests/*
  under: [remote "github"]
  add:       fetch = +refs/pull/*:refs/remotes/github/pr/*

Many projects use merges but, to keep things as consistent as possible
with current practices, for now I would cherry-pick individual pull
requests and amend the commit to add a ChangeLog entry and reference
to the commit message. For ChangeLog entries and commit messages, the
references might be something like "MR: #1". Or do we need to be more
explicit, e.g. "github PR: #1"?

Any comments or suggestions would be welcome.


Messages sorted by: Reverse Date, Date, Thread, Author