Re: $userdirs empty in non-interactive shells

[Stephane Chazelas <stephane.chazelas@xxxxxxxxx>]

2017-12-07 11:29:50 +0000, Stephane Chazelas:
[...]
> >     /* We don't maintain a hash table in non-interactive shells. */
> >     if (!interact)
> >         return;
[...]

If I remove that code, that breaks one of the tests:

> --- /tmp/zsh.ztst.2996/ztst.out 2017-12-07 21:31:18.051388484 +0000
> +++ /tmp/zsh.ztst.2996/ztst.tout        2017-12-07 21:31:18.047388673 +0000
> @@ -1,4 +1,4 @@
>  ~/install/cvs/zsh/Test/options.tmp
> -~/install/cvs/zsh/Test/options.tmp/tmpcd ~/install/cvs/zsh/Test/options.tmp
> -~/install/cvs/zsh/Test/options.tmp/tmpcd ~/install/cvs/zsh/Test/options.tmp/tmpcd ~/install/cvs/zsh/Test/options.tmp
> -~/install/cvs/zsh/Test/options.tmp/tmpcd ~/install/cvs/zsh/Test/options.tmp/tmpcd ~/install/cvs/zsh/Test/options.tmp
> +~cdablevar2 ~/install/cvs/zsh/Test/options.tmp
> +~cdablevar2 ~cdablevar2 ~/install/cvs/zsh/Test/options.tmp
> +~cdablevar2 ~cdablevar2 ~/install/cvs/zsh/Test/options.tmp
> Test ./E01options.ztst failed: output differs from expected as shown above for:
>   dirs
>   pushd $mydir/tmpcd
>   dirs
>   pushd $mydir/tmpcd
>   dirs
>   setopt pushdignoredups
>   pushd $mydir/tmpcd
>   dirs
>   unsetopt pushdignoredups
>   popd >/dev/null
>   popd >/dev/null
> Was testing: PUSHD_IGNOREDUPS option
> ./E01options.ztst: test failed.

That's because an earlier test does a cd a:

cd cdablevar2

under setopt cdablevars with cdablevar2 containing that same
tmpcd directory, and so an entry is added in that hash.

That's one case where an earlier test has side effects on later
tests.

While the documentation doesn't mentions that that "hashing" only
happens in interactve shells, the test code acknowleges it to
some extent:

># Test various shell options.
># Interactive options not tested here:
[...]
>#    AUTO_NAME_DIRS  (named directory table not maintained)

That also means:

$ zsh -fc 'cd ~bin; dirs'
/bin
$ zsh -fic 'cd ~bin; dirs'
~bin

BTW, I just realised that named dirs in variables took precedence
over user home dirs:

$ zsh -fc 'cd -P -- ~bin && pwd'
/bin
$ bin=/tmp zsh -fc 'cd -P -- ~bin && pwd'
/tmp

Is that intentional? I can't say I like the  idea. It would need
to be disabled in "sh" emulation if we wanted to be POSIX
compliant in that regard (but then there are a few other
namespace clashes that would need to be addressed like for
keywords, special variables if we wanted to go all the way
there).

-- 
Stephane