Zsh Mailing List Archive
Messages sorted by:
Re: RFC: [PATCH] Completion/Unix/Command/_git: replace a few "*::" with "*:"
- X-seq: zsh-workers 44079
- From: dana <dana@xxxxxxx>
- To: Daniel Hahler <genml+zsh-workers@xxxxxxxxxx>
- Subject: Re: RFC: [PATCH] Completion/Unix/Command/_git: replace a few "*::" with "*:"
- Date: Sun, 24 Feb 2019 13:46:40 -0600
- Cc: zsh-workers@xxxxxxx
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dana-is.20150623.gappssmtp.com; s=20150623; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=k3jgz4hTKbSCCakzsEyI5NK7TH+fGK+/pLJegwzeT9I=; b=g5SGPtboueo6U8959CHwGFHqQrP3DLcWzDIk+Fe2icdMsG96TtXrKQnA9oS+3Kk6Jb PY8LvqYXFM8zM8EwpDnpEdMFv67zvnz0i8+JloGt0gg1CO2bwqm8CsmOrB8ZDsF0ftti eAuQ5dhl5cI84d9/163NAhuhJJpEedKexknp+Ava0OvFd/fFLrgwgy2UvRF4yNrw5xn5 S7dnw3lguCbSiFpDLXx5igH1Kufodw8vKIO1pJOK7kYu4IaioP4o13uime9aMDocDkDS iSqPMeV38YvNi4W8UtbG9NQwsInD5B607Nwnjs7ANJsxkxaO5+B6LN3UzF+zcwuTzpT8 DLYg==
- In-reply-to: <email@example.com>
- List-help: <mailto:firstname.lastname@example.org>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:email@example.com>
- List-unsubscribe: <mailto:firstname.lastname@example.org>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
- References: <email@example.com>
On 24 Feb 2019, at 07:58, Daniel Hahler <genml+zsh-workers@xxxxxxxxxx> wrote:
>This patch changes some of the "*::" to "*:", but is not really tested
>in detail. Mostly based on trying if "--help" worked after any arg.
Some of these do look like they were just erroneously copied and pasted, but
in other cases it's actually necessary, at least with the way it's written
now. For example, the commit-range-or-file state checks to see if $CURRENT is
1, which can only ever be true if the *:: syntax (or equivalent) is used.
I didn't look at it much harder than that, but, in general, anywhere you're
thinking about removing *:: or *:::, you need to check the corresponding state
code to see if it does anything with $words or $CURRENT, or calls another
function that does.
Messages sorted by: