Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: Fwd: Re: [PATCH] {,un}applychange: do not call zle_setline(NULL) if quietgethist() fails

On Wednesday, June 26, 2019 1:00:44 PM CEST Peter Stephenson wrote:
> > On 26 June 2019 at 11:19 Kamil Dudka <kdudka@xxxxxxxxxx> wrote:
> > 
> > 
> > There is a bug report in Red Hat Bugzilla about zsh crashing on NULL
> > pointer dereference: https://bugzilla.redhat.com/1722703
> > 
> > I was not able to reproduce the crash myself but the attached patch
> > should prevent zsh from crashing in this situation.
> Hmm... I'm guessing that in the failure case we probably shouldn't
> set zlecs either?  It's probably not going to do anything helpful.
> Possibly also return 1?
> pws

Good point.  zlecs should not be updated when zleline is not updated.
Sorry for missing it in the proposed patch.  Returning 1 might also be
better although I do not really understand why quietgethist() returns
NULL in the mentioned case.


Messages sorted by: Reverse Date, Date, Thread, Author